Ed Morley [:emorley] Reporter
	Description • 9 years ago

Currently the log viewer displays only failed steps, unless the "show successful steps" checkbox is ticked (or there are no failed steps at all).

However a step with status of "skipped" is counted as failed, which if all steps had a status of "success" except one that has a status of "skipped", then the log viewer doesn't show the successful steps by default. eg:
https://treeherder.allizom.org/logviewer.html#?job_id=9117571&repo=mozilla-inbound

We should make hasFailedSteps() return False for both the result state of "skipped" as well as "success":
https://github.com/mozilla/treeherder/blob/d0bb90a2eefd49deb31349a7a6f5caa1d71d5069/ui/js/controllers/logviewer.js#L54

	Jonathan French (:jfrench) Assignee
	Comment 1 • 9 years ago

Please see tweak PR for review, hopefully this addresses the scenarios correctly.

	Treeherder GitHub Bugbot
	Comment 2 • 9 years ago

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/60af18fdaa018d99ee2e5e97e0346534cb49d315
Bug 1192198 - Evaluate a skipped step as a non-failure

	Jonathan French (:jfrench) Assignee
	Comment 3 • 9 years ago

Marking fixed per above merge. Will verify on the next push to stage/prod.

	Jonathan French (:jfrench) Assignee
	Comment 4 • 9 years ago

Verified fixed on stage and prod.

There may be some other cases to handle, but this particular bug appears fixed. We display skipped steps by default in failed jobs, and display all successful steps and skipped steps by default for successful jobs.