Closed
Bug 1192195
Opened 9 years ago
Closed 9 years ago
Log viewer is missing styling for result-status-shading-skipped
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: emorley, Assigned: jfrench)
References
Details
Attachments
(3 files)
One of the buildbot statuses is "skipped": https://github.com/mozilla/treeherder/blob/6bf44c89e1674e9272d25913ab4dbe13d581100d/treeherder/etl/buildbot.py#L11 Which results in a CSS class in the logviewer of "result-status-shading-skipped". However there is no styling for that class, eg: https://treeherder.allizom.org/logviewer.html#?job_id=9117571&repo=mozilla-inbound
Assignee | ||
Comment 1•9 years ago
|
||
In our current color palette, we haven't yet used bootstrap-esque 'info' blue. Ed do you think that would be suitable to represent a skipped step? (and perhaps a skipped job if we ever need to represent such a thing in Treeherder later). http://getbootstrap.com/components/#alerts (see info blue) Current Treeherder job colors https://treeherder.mozilla.org/help.html
Flags: needinfo?(emorley)
Assignee | ||
Comment 2•9 years ago
|
||
Here's a proposed appearance, it seems to match bootstrap 'info' pretty closely, given the added 0.25 opacity all the result-status-shading classes receive.
Reporter | ||
Comment 3•9 years ago
|
||
Yeah that wfm; so long as it doesn't look too close to the retry colour so as to be confusing? :-)
Flags: needinfo?(emorley)
Assignee | ||
Comment 4•9 years ago
|
||
It seems enough of a difference from retry in logviewer, I think? I've attached a screen grab with the two side by side. I think retry is a bit strange tbh, in treeherder its dark navy blue and in logviewer with the opacity at 0.25 it's sort of purpley. I'll investigate the result-status alpha/opacity values in general at some point. Perhaps they could all be converted to solid.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
OS: Unspecified → All
Hardware: Unspecified → All
Assignee | ||
Comment 5•9 years ago
|
||
Please see above PR for status/review.
Attachment #8645033 -
Flags: review?(emorley)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8645033 [details] [review] PR 845 Looks much better, thank you :-)
Attachment #8645033 -
Flags: review?(emorley) → review+
Comment 7•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/6130e1f6eb48e1870c8203a0ee8b6e504e0ff8da Bug 1192195 - Provide a style for result-status skipped
Assignee | ||
Comment 8•9 years ago
|
||
Marking fixed per above merge. Will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Component: Treeherder: Log Viewer → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•