Edouard Oger [:eoger] Reporter
	Description • 9 years ago

See attached gif. It could help users identify which forms inputs were filled in the current page.

	Bernardo Rittmeyer [:rittme]
	Comment 1 • 9 years ago

This would probably be a nice visual indication of the inputs filled by the password manager context menu form fill (bug 433238) or the fill doorhanger (bug 1129528).

	Matthew N. [:MattN]
	Comment 2 • 9 years ago

Styling the inputs in the content area can be quite fragile so we've been avoiding it so far. Of course that doesn't mean we can't try it.

	Edouard Oger [:eoger] Reporter
	Comment 3 • 9 years ago

We could use rfeeley's input on this one!

	Ryan Feeley [:rfeeley]
	Comment 4 • 9 years ago

It's a good idea, and one I've been thinking about too. A little animation might help the user understand that we’re doing something for them. 1Password doesn't use colour but merely pops the text a little. I'm going to needinfo from shorlander on this as he may have something for us.

	Stephen Horlander [:shorlander]
	Comment 5 • 9 years ago

(In reply to Ryan Feeley from comment #4)
> Created attachment 8643100 [details]
> fill-animation.gif
> 
> It's a good idea, and one I've been thinking about too. A little animation
> might help the user understand that we’re doing something for them.
> 1Password doesn't use colour but merely pops the text a little. I'm going to
> needinfo from shorlander on this as he may have something for us.

I like the bounce. Feels like something is being plopped there.

	Ryan Feeley [:rfeeley]
	Comment 6 • 9 years ago

I spoke with Stephen and the team about this. They felt strongly that the yellow should persist. I came up with this based on their feedback. What do you think? Colour is #FFFF9B. http://people.mozilla.org/~rfeeley/images/golden.gif

	Matthew N. [:MattN]
	Comment 7 • 9 years ago

I'm pretty sure ckarlof suggested we avoid modifying the page as he had bad experiences doing that in the past. I think it's much less likely that an animation interferes with the page than changing colours so I'd rather we only do an animation if we're doing this. Also, if the page is doing something unusual, there will only be a problem during the animation duration whereas a colour/style clash will continue to be a problem.

For example: consider a page with a dark theme where the text (bullet) colour is yellow (maybe on black), I'm assuming we don't want yellow-on-yellow with this suggestion but ideally this would be a CSS-only change and CSS can't do different things based on the computed colours.

	Chris Karlof [:ckarlof]
	Comment 8 • 9 years ago

Indeed, I would avoid styling the page in any way because the worst case failure cases can be bad. "Overlays" are less bad, but depending on how styled they are, they can also visually clash in unexpected ways with the page. 

The autocomplete UI is IMO, a good demonstration of how to be conservative. It's so simple that it's unlikely clash. It ain't much to look at, either, though. :)

	Ryan Feeley [:rfeeley]
	Comment 9 • 9 years ago

MattN: I think that a color like hsla(58,100%,50%,0.33) would work on most backgrounds (except yellow). I do worry about the performance impact of an animation (now with reduced opacity). Thoughts?

	Ryan Feeley [:rfeeley]
	Comment 10 • 8 years ago

I noticed how you animate in focus in your awesomebar mockups. Do you imagine this treatment would also be relevant for when we autofill fields like username, password and beyond?

	Stephen Horlander [:shorlander]
	Comment 11 • 8 years ago

(In reply to Ryan Feeley [:rfeeley] from comment #10)
> I noticed how you animate in focus in your awesomebar mockups. Do you
> imagine this treatment would also be relevant for when we autofill fields
> like username, password and beyond?

That was specifically to mimic the native focus behavior. I think whatever we do to incontent forms would have to be flexible enough to handle whatever styling the site has.

	Pulsebot
	Comment 17 • 5 years ago

Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcfe1e75c501
Provide visual feedback to the user when login fields are autofilled and autocompleted. r=MattN