Kim Moir [:kmoir] ET Assignee
	Description • 9 years ago

remove platform buildbot-configs, buildbotcustom, devices.json in tools, slave health etc.

	Kim Moir [:kmoir] ET Assignee
	Comment 2 • 8 years ago

actually I will use this bug to remove dead panda code

	Kim Moir [:kmoir] ET Assignee
	Comment 3 • 8 years ago

patches to remove references to pandas, foopies, bmm and mozpool from tools repo

	Kim Moir [:kmoir] ET Assignee
	Comment 9 • 8 years ago

remove mh scripts on inbound for panda and panda talos

	Joel Maher ( :jmaher ) (UTC -8)
	Comment 10 • 8 years ago

Comment on attachment 8729155 [details] [diff] [review]
bug1186617mh.patch

Review of attachment 8729155 [details] [diff] [review]:
-----------------------------------------------------------------

so beautiful!

	Pulsebot
	Comment 11 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/d83f22ef3d5c

	Kim Moir [:kmoir] ET Assignee
	Comment 12 • 8 years ago

I removed the pandas and bm89 and 100-102 from the slavealloc databases too

	Carsten Book [:Tomcat]
	Comment 13 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d83f22ef3d5c

	Chris Cooper [:coop] (he/him)
	Comment 14 • 8 years ago

Comment on attachment 8729131 [details] [diff] [review]
bug1186617sh.patch

Review of attachment 8729131 [details] [diff] [review]:
-----------------------------------------------------------------

We'll want to watch when this lands that it doesn't break on historical panda data in the db. Problems should appear as unknown entries on the index page.

	Release Engineering SlaveAPI Service
	Comment 15 • 8 years ago

In production: https://hg.mozilla.org/build/buildbotcustom/rev/695299094ba0

	Chris Cooper [:coop] (he/him)
	Comment 16 • 8 years ago

Streamlining our reconfig process a bit now that foopies are no more.

	Kim Moir [:kmoir] ET Assignee
	Comment 17 • 8 years ago

Comment on attachment 8729623 [details] [diff] [review]
[tools] Remove foopies from end-to-end reconfig script

Thanks!

I actually included this in https://bug1186617.bmoattachments.org/attachment.cgi?id=8729107 yesterday but didn't ask for review yet

	Chris Cooper [:coop] (he/him)
	Comment 18 • 8 years ago

Comment on attachment 8729623 [details] [diff] [review]
[tools] Remove foopies from end-to-end reconfig script

(In reply to Kim Moir [:kmoir] from comment #17) 
> I actually included this in
> https://bug1186617.bmoattachments.org/attachment.cgi?id=8729107 yesterday
> but didn't ask for review yet

OK, let's go with your more complete patch. Let me know when you want review.

	Chris Cooper [:coop] (he/him)
	Comment 19 • 8 years ago

Comment on attachment 8729107 [details] [diff] [review]
bug1186617tools.patch

Review of attachment 8729107 [details] [diff] [review]:
-----------------------------------------------------------------

Can I get you to tag the tools repo *before* you land this patch with PANDA_FOOPY_SUTLIB (or something better, naming things is hard) so we can easily find this code again in the future if we need to?

Nit: you have trailing whitespace on some of your patched files. Might want to add something like https://github.com/ccooper/dotfiles/blob/master/.vimrc#L56 to your .vimrc file.

	Kim Moir [:kmoir] ET Assignee
	Comment 20 • 8 years ago

patch with whitespace fixed

	Kim Moir [:kmoir] ET Assignee
	Comment 21 • 8 years ago

tagged as PANDA_FOOPY_SUTLIB_20160314 before landing patch

	Kim Moir [:kmoir] ET Assignee
	Comment 23 • 8 years ago

I ran a machine in staging against this patched puppet env and it worked fine.

	Dustin J. Mitchell [:dustin] (he/him)
	Comment 24 • 8 years ago

Comment on attachment 8730320 [details] [diff] [review]
bug1186617puppet.patch

Review of attachment 8730320 [details] [diff] [review]:
-----------------------------------------------------------------

What a sea of `-`.. I love it

The /data/bmm directory should also be deleted (maybe check with Jake to see if we should back it up somewhere first), and the mozpool-related secrets removed, too.

::: modules/slaveapi/manifests/instance.pp
@@ -63,5 @@
>                  "furl==0.3.5",
>                  "orderedmultidict==0.7.1",
>                  "pytz==2013.7",
>                  "slaveapi==${version}",
> -                "mozpoolclient==0.1.5",

Does slaveapi need to be updated first?  Without mozpoolclient, will we get ImportErrors?

	Kim Moir [:kmoir] ET Assignee
	Comment 25 • 8 years ago

dividehex: should the /data/bmm directory be backed up before we delete it?

	Kim Moir [:kmoir] ET Assignee
	Comment 26 • 8 years ago

Comment on attachment 8729131 [details] [diff] [review]
bug1186617sh.patch

due to bug 1256375

	Kim Moir [:kmoir] ET Assignee
	Comment 27 • 8 years ago

changes to slave api to remove mozpoollclient are in bug 1256375

	Jake Watkins [:dividehex]
	Comment 28 • 8 years ago

(In reply to Kim Moir [:kmoir] from comment #25)
> dividehex: should the /data/bmm directory be backed up before we delete it?

Well, I don't ever see this project being resurrected from the dead but just for nostalgia I've taken a tarball of bmm.  You can go ahead and remove it from /data

	Kim Moir [:kmoir] ET Assignee
	Comment 29 • 8 years ago

closing - I think I have removed all the panda code.

	Kim Moir [:kmoir] ET Assignee
	Comment 30 • 8 years ago

fix slave_health crontab to not copy devices.json

	Kim Moir [:kmoir] ET Assignee
	Comment 31 • 8 years ago

Comment on attachment 8732351 [details] [diff] [review]
bug1186617sh-2.patch

and updated slave_health on cruncher manually and now the worker health web page is updating again