Closed Bug 1185641 Opened 9 years ago Closed 9 years ago

[Aries][Settings] Hardware Composer should be disabled by default due to phone reset from Dev Mode.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master verified)

VERIFIED FIXED
Tracking Status
b2g-master --- verified

People

(Reporter: Marty, Assigned: yzen)

References

Details

(Whiteboard: [2.5-Daily-Testing][Spark])

Attachments

(2 files, 1 obsolete file)

Attached file logcat-fmd-in-call.txt (obsolete) —
Description:
The Hardware Composer has been causing several issues with current builds, and is currently disabled by default on the Aries Dogfood RC4 build.  However, the latest Aries builds still have HWC enabled, so even after running an OTA from RC4, if the user performs a system reset, HWC will be turned back on, re-exhibiting these issues.

These bugs appear to be caused by HWC:
Bug 1174810
Bug 1176301

Repro Steps:
1) Update a Aries to 20150720101908
2) Open Settings and navigate to Developer Settings
3) Scroll down to Hardware Composer

Actual:
Hardware Composer is enabled.

Expected:
Hardware Composer is disabled.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150720101908
Gaia: a47e0c58dd1340a17be7cc96ccd90fcad15a922b
Gecko: 5df788c56ae7
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: logcat
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
Attached file logcat-hwc.txt
Accidentally attached the wrong logcat. Apologies.
Attachment #8636144 - Attachment is obsolete: true
Having Hardware Composer enabled causes a multitude of issues on the Aries device.  

Doug/Naoki,

Is having it disabled a temporary workaround for these issues or a permanent fix?  If perm. we need to fix it so resetting to factory settings on an Aries device doesn't flip it to enabled.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga)
Flags: needinfo?(nhirata.bugzilla)
Flags: needinfo?(drs)
Summary: [Settings] Hardware Composer should be disabled by default in developer settings. → [Aries][Settings] Hardware Composer should be disabled by default in developer settings.
The hardware composer should be off by default if you do a OTA from the RC4.  

If it flips on we need a different bug filed in regards to the preference turning on by itself.
The preference should not be adjusted based on OTA.
Flags: needinfo?(pbylenga)
It's not, this bug is tracking it turning on after resetting to factory settings on RC4 + OTA.

1. RC4 has it turned off
2. after OTA has it turned off
3. Resetting to factory settings (ie. to enable dev mode for spark apps) turns it on
Flags: needinfo?(pbylenga)
Sorry, Dev Settings didn't make sense to me initially.
So we need to make a patch to dev mode settings to add the preference to turn HWC off there.

Doug or Justin?  Could you guys make a quick patch here please?  Otherwise I guess I could try to look at where to add the pref.
Flags: needinfo?(jdarcangelo)
Summary: [Aries][Settings] Hardware Composer should be disabled by default in developer settings. → [Aries][Settings] Hardware Composer should be disabled by default due to phone reset from Dev Mode.
I think yzen would be better to make the patch since he made a patch for bug 1170263; Could you please look into doing so?  I suppose based on the patch in the previous bug, I can make a quick patch.
Flags: needinfo?(yzenevich)
Flags: needinfo?(jdarcangelo)
Flags: needinfo?(drs)
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Flags: needinfo?(yzenevich)
Hi Naoki, just a couple of questions:
* is this aries only or all (e.g. master) version of behaviour?
* do we want to disable the setting by default always? or only if full dev mode is on?
Just Aries please.  It's a gonk issue on aries.
 "HARDWARE_COMPOSER": 0

If you can do it in general and full dev mode for the aries device, that would be awesome.  Otherwise, full dev mode for aries please.
Flags: needinfo?(nhirata.bugzilla) → needinfo?(yzenevich)
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #8)
> Just Aries please.  It's a gonk issue on aries.
>  "HARDWARE_COMPOSER": 0
> 
> If you can do it in general and full dev mode for the aries device, that
> would be awesome.  Otherwise, full dev mode for aries please.

Ok I think it's possible to disable hardware composing for all in full dev mode. But if we do revert to factory (unset full dev mode) what do we do about the setting then, set it to true?
Flags: needinfo?(yzenevich) → needinfo?(nhirata.bugzilla)
Oh, you're right.  I guess we would have to set the settings.json to have the hardware composer off for aries in general.

Also to note, we need to be able to back out of the patch once we have all the fixes we need to turn the hardware composer back on.
Flags: needinfo?(nhirata.bugzilla) → needinfo?(yzenevich)
Comment on attachment 8640565 [details] [review]
[gaia] yzen:bug-1185641 > mozilla-b2g:master

Changing hardware composer setting default to false for spark builds.
Flags: needinfo?(yzenevich)
Attachment #8640565 - Flags: review?(ehung)
Comment on attachment 8640565 [details] [review]
[gaia] yzen:bug-1185641 > mozilla-b2g:master

thanks!
Attachment #8640565 - Flags: review?(ehung) → review+
https://github.com/mozilla-b2g/gaia/commit/c207213f31eb5b92ad5c98bb89357d09d22783ae
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Marty can you verify this as fixed?
Flags: needinfo?(mshuman)
Keywords: verifyme
This issue is verified fixed in the latest Spark Aries 2.5 build.
Hardware Composer is Disabled by default on a fresh flash of the build.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150803134730
Gaia: 8dba2077f5e7137253fbb3faf10cd0b5f7da25c2
Gecko: 1d4f44ee5166
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(mshuman) → needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Blocks: 1223953
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: