Closed Bug 1185051 Opened 9 years ago Closed 9 years ago

[B2G] Manage the sound of any website which is opened from the browser app

Categories

(Firefox OS Graveyard :: Gaia::System::Audio Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Audio Mgmt
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-master verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.2 --- unaffected
b2g-master --- verified

People

(Reporter: Marty, Assigned: evanxd)

References

(
URL
)

Details

(Keywords: regression, smoketest, Whiteboard: [2.5-Daily-Testing][Spark], [dogfood-blocker])

Attachments

(2 files)

youtube-logcat.txt
377.33 KB, text/plain
Details
Patch: https://github.com/mozilla-b2g/gaia/pull/31050
46 bytes, text/x-github-pull-request
johnhu
: review+
alive
: feedback+
Details | Review
Attached file youtube-logcat.txt — 
Description:
If the user is watching a youtube video and they navigate away from the browser window, such as going to homescreen, opening an SMS notification, or edge gesturing to another app, the video will continue playing.

This issue will cause audio to overlap with audio from the Music app, and will prevent the Video app from playing videos entirely.

Repro Steps:
1) Update an Aries to 20150717125848
2) Connect to a WiFi or Cellular Data network and open the Browser app.
3) Navigate to YouTube and begin playing a video
4) Press the Home button

Actual:
YouTube video continues playing at the homescreen.

Expected:
YouTube video stops playing at the homescreen, and resumes upon returning to the app.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150717125848
Gaia: 77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36
Gecko: 15155971639c
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: Video (URL), Logcat
This issue DOES occur on the latest Flame 2.5 build.
YouTube video continues playing at the homescreen.

Environmental Variables:
Device: Flame 2.5
Build ID: 20150717010206
Gaia: 77bc0d940bde2a5d2d4dfadfcccc6d8d77456d36
Gecko: 8d262d1d0ae5
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

------------------------------------------------

This isssue does NOT occur on Flame 2.2 builds.
YouTube video stops playing at the homescreen, and resumes upon returning to the app.

Environmental Variables:
Device: Flame 2.2
Build ID: 20150715002506
Gaia: 84d0c76370dcd3d25813b00de55194730884355b
Gecko: a5db6d9850f6
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(pbylenga)
[Blocking Requested - why for this release]:
Functional regression

Requesting a window, there were some recent changes to audio channel policy.
blocking-b2g: --- → 2.5?
Flags: needinfo?(pbylenga)
Keywords: regressionwindow-wanted
QA Contact: ktucker
Mozilla Inbound

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150710163851
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: 07bcf36f5ab2
Version: 42.0a1 (2.5)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150710170452
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: 675ea719b91c
Version: 42.0a1 (2.5)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working Gaia First Broken Gecko: Issue DOES reproduce
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: 675ea719b91c

First Broken Gaia Last Working Gecko: Issue DOES NOT reproduce
Gaia: e4b63559eba364892867eb381c3002d6518e5d6a
Gecko: 07bcf36f5ab2

Gecko pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=07bcf36f5ab2&tochange=675ea719b91c

This looks to have been caused by bug 1113086.
Blocks: 1113086
Flags: needinfo?(pbylenga)
Keywords: regressionwindow-wanted
Andrea, can you take a look at this please? This looks to be another issue caused by the landing for bug 1113086.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini) → needinfo?(alwu)
Flags: needinfo?(pbylenga)
Hi, Martin,
I can't reproduce this issue with the latest Gecko and Gaia.
The gaia audio policy manager should stop the youtube when it became background, could you help me test it again?
Thanks!
Flags: needinfo?(alwu) → needinfo?(mshuman)
Ah, I can reproduce it now.
Checking for more details.
Flags: needinfo?(mshuman)
After discuss with Evan, we found the root cause of this issue.

This bug only happened when we open the youtube from the Browser app. It would not exist if you open the youtube from the rocket bar. Sound weird, right?

The audio of iframe would be managed by the AudioChannelController, which is created when the system app open the new app window for that iframe. However, when we open any web page by the browser app, it doesn't create any app window. It would dynamically create a new iframe to replace the previous one. 

No app window means that no AudioChannelController, so that we can't control its audio.

Now we need to figure why the browser app would have this special behavior - "doesn't create new app window when open a new page".
Alastor, are you the right assignee here?
Flags: needinfo?(alwu)
blocking-b2g: 2.5? → 2.5+
Because this issue should be solved by the Gaia modification, Evan would take it,
Component: Gaia::Browser → Gaia::System::Audio Mgmt
Flags: needinfo?(alwu) → needinfo?(evanxd)
Flags: needinfo?(evanxd)

    
  
Assignee: nobody → evanxd

    
  

        Attachment #8636397 -
        Attachment description: WIP Patch: https://github.com/mozilla-b2g/gaia/pull/31050 → Patch: https://github.com/mozilla-b2g/gaia/pull/31050

    
    

    
  
Comment on attachment 8636397 [details] [review]
Patch: https://github.com/mozilla-b2g/gaia/pull/31050

Hi Alive,

Could you give feedback for the patch?

Thanks.

        Attachment #8636397 -
        Flags: feedback?(alegnadise+moz)

    
    

    
  
Now we can't manage the sound of the website which is opened from the browser app, that is because the browser app would dynamically create a new iframe to replace the old one, instead of opening a new app window.

This behavior would not trigger to creating the audio channel controller, so that we can't manage its sound.

    
  
Summary: [Browser][YouTube] YouTube videos continue to play in the background of homescreen, other apps. → [B2G] Manage the sound of any website which is opened from the browser app

    
  
Blocks: 1130350

    
    

    
  
Alive thanks for the feedback.

    
    

    
  
Comment on attachment 8636397 [details] [review]
Patch: https://github.com/mozilla-b2g/gaia/pull/31050

Hi Alive,

Same patch and added tests.
If anything is just good, could you give r+ here.

Thanks.

        Attachment #8636397 -
        Flags: review?(alegnadise+moz)
Whiteboard: [2.5-Daily-Testing][Spark][systemsfe] → [2.5-Daily-Testing][Spark]
Whiteboard: [2.5-Daily-Testing][Spark] → [2.5-Daily-Testing][Spark], [dogfood-blocker]

    
    

    
  
Comment on attachment 8636397 [details] [review]
Patch: https://github.com/mozilla-b2g/gaia/pull/31050

Hi John,

Could you help to review the patch?
Alive already gave it f+.

Thanks.

        Attachment #8636397 -
        Flags: review?(alegnadise+moz) → review?(im)

    
    

    
  
John, thanks for the review.

    
    

    
  
John, thanks for the review.

    
    

    
  
Treeherder looks like broken. Let's land the code once it is fixed and all tasks are good.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
This issue is verified fixed in the latest Spark 2.5 build.
YouTube videos play correctly, and do not continue to play at the homescreen.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150727151800
Gaia: 4e3e21a4ba3f188b45623ee2297f21d0791f8667
Gecko: 21ca97268bae
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]

          status-b2g-master:
          affected → verified
Flags: needinfo?(onelson)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(onelson)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: