Martijn Wargers (dead) Reporter
	Description • 9 years ago

We have failures like these on Jenkins:
http://jenkins1.qa.scl3.mozilla.com/view/Bitbar/job/flame-kk-319.b2g-inbound.tinderbox.ui.functional.smoke.bitbar/2255/testReport/%28root%29/test_settings_wifi_py%20TestSettingsWifi_test_connect_to_wifi_via_settings_app/test_settings_wifi_py_TestSettingsWifi_test_connect_to_wifi_via_settings_app/
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/flame-kk-319.b2g-inbound.tinderbox.ui.functional.smoke.bitbar/workspace@2/.env/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/var/lib/jenkins/jobs/flame-kk-319.b2g-inbound.tinderbox.ui.functional.smoke.bitbar/workspace@2/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_wifi.py", line 21, in test_connect_to_wifi_via_settings_app
    wifi_settings = settings.open_wifi_settings()

AttributeError: 'Settings' object has no attribute 'open_wifi_settings'

This is because of the pull request in bug 1180819.

These places need fixing:
mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_wifi.py#21
http://mxr.mozilla.org/gaia/search?string=open_cell_and_data_settings

	Martijn Wargers (dead) Reporter
	Comment 1 • 9 years ago

Hrm, and more cases:
http://mxr.mozilla.org/gaia/search?string=open_sound_settings
http://mxr.mozilla.org/gaia/search?string=open_keyboard_settings&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
http://mxr.mozilla.org/gaia/search?string=open_bluetooth_settings&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
http://mxr.mozilla.org/gaia/search?string=a11y_open_accessibility_settings&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
http://mxr.mozilla.org/gaia/search?string=open_language_settings&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
http://mxr.mozilla.org/gaia/search?string=open_do_not_track_settings&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
http://mxr.mozilla.org/gaia/search?string=open_media_storage_settings&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=gaia
etc..

	No-Jun Park [:njpark] Assignee
	Comment 3 • 9 years ago

Comment on attachment 8635421 [details] [review]
[gaia] npark-mozilla:1184981 > mozilla-b2g:master

Tested locally on a device without sim card, looks okay to me

	Martijn Wargers (dead) Reporter
	Comment 4 • 9 years ago

Comment on attachment 8635421 [details] [review]
[gaia] npark-mozilla:1184981 > mozilla-b2g:master

R+ without trying out myself, the patch looks fine to me.

	No-Jun Park [:njpark] Assignee
	Comment 5 • 9 years ago

Merged:
https://github.com/mozilla-b2g/gaia/commit/21c19b0e927af6492167a067171e1b78e4cbd878