Nicholas Nethercote [inactive] Assignee
	Description • 9 years ago

Because iterators are so much nicer than enumerate functions.

There are two occurrences of EnumerateEntries() in accessible/ to be dealt with.

	Nicholas Nethercote [inactive] Assignee
	Comment 2 • 9 years ago

Here's a |diff -w| version of the patch that is a lot easier to read.

	Trevor Saunders (:tbsaunde)
	Comment 3 • 9 years ago

Comment on attachment 8637654 [details] [diff] [review]
Use nsTHashTable::Iterator in accessible/

thanks, I'm swamped with a11y e10s so don't have time for cleaning stuff up :/

>   // Process rendered text change notifications.
>-  mTextHash.EnumerateEntries(TextEnumerator, mDocument);
>+  ProcessRenderedTextChangeNotifications();
>   mTextHash.Clear();


it might make more sense for that to be part of ProcessRenderedText, but up to you.

	Nicholas Nethercote [inactive] Assignee
	Comment 4 • 9 years ago

Thank you for the fast review.

> it might make more sense for that to be part of ProcessRenderedText, but up
> to you.

In this case I left it as a separate function because the loop body was large, but I'm happy to inline it and will do so.

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/51afd4c6a44e

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/51afd4c6a44e