Yura Zenevich [:yzen] (please use "needinfo") Reporter
	Description • 9 years ago

Android now has a pronounced outline of virtual cursor focus. We only duplicate it and thus do not need it for the most part. 

The only exception is a word and character modes where we would have our highlight inside the android one since it's not supported natively.

	Eitan Isaacson [:eeejay]
	Comment 2 • 9 years ago

Comment on attachment 8648581 [details] [diff] [review]
Patch

Review of attachment 8648581 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this.

I had a different idea about how to implement this..

I think the highlight for accessible objects and text ranges should be two different HTML elements, and they should be styled visible or not depending on platform.
So, in Android, the accessible object one would be invisible, and the text range one visible. In B2G, they would both be visible.

Maybe i'll make some visual mockups of what I was thinking..

If you think that is a bad idea, please tell!!

::: accessible/jsat/Presentation.jsm
@@ +186,5 @@
>        return {
>          type: this.type,
>          details: {
>            eventType: 'viewport-change',
> +          shouldHideBounds: !this._hasBoundstoPresent(start, end),

I would relay the type of bounds (text range, or accessible object), and then the Output.Visual in Accessfu.jsm would discern, depending on platform what to do. This will allow in the future to have two separate highlights for object and characters. For example, in B2G, we may want to highlight the parent object in one color/style, and have an inner rectangle around the spoken word.