Closed
Bug 1179267
Opened 9 years ago
Closed 9 years ago
test_ftu_skip_tour.py: "Timed out after 10.1 seconds with message: Send Data UI state should match initial internal state"
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: onelson, Assigned: martijn.martijn)
References
()
Details
Attachments
(1 file)
Description: test_ftu_skip_tour.py is failing 100% of the time currently. It was thought to be the same issue presented by this functional regression (bug 1178543) but with that issue now verified on flame devices of the same gaia. There was a previous issue with this checkbox in ftu that may have created new behavior that caused this regression in the aftermath of the fix: bug 1134257 * http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk-319.mozilla-central.nightly.ui.functional.smoke.bitbar/258/HTML_Report/ * http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc.bitbar/113/HTML_Report/ Repro Steps: 1) Update phone to 20150701010205 2) Progress through FTU to 'Send Data to Firefox' screen 3) Observe checkbox Actual: Checkbox is checked initially by design, but test fails Expected: Checkbox is checcked initially by design, and test proceeds Traceback (most recent call last): File "/var/lib/jenkins/jobs/flame-kk-319.mozilla-central.nightly.ui.functional.smoke.bitbar/workspace/.env/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/var/lib/jenkins/jobs/flame-kk-319.mozilla-central.nightly.ui.functional.smoke.bitbar/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_skip_tour.py", line 107, in test_ftu_skip_tour message="Send Data UI state should match initial internal state") File "/var/lib/jenkins/jobs/flame-kk-319.mozilla-central.nightly.ui.functional.smoke.bitbar/workspace/.env/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/wait.py", line 143, in until cause=last_exc) TimeoutException: TimeoutException: Timed out after 10.1 seconds with message: Send Data UI state should match initial internal state Environmental Variables: Device firmware (base) L1TC100118D0 Device firmware (date) 01 Jul 2015 08:40:39 Device firmware (incremental) eng.cltbld.20150701.044026 Device firmware (release) 4.4.2 Device identifier flame Device memory 219772 kB Device serial f30ecc97 Device uptime 0 days 0 hours 2 minutes 12 seconds Gaia date 30 Jun 2015 20:07:47 Gaia revision 90ed5ebde89b Gecko build 20150701010205 Gecko revision 079b6f1ae1c3 Gecko version 42.0a1 Reproducible manually: NO Repro frequency: 5/5
Assignee | ||
Comment 1•9 years ago
|
||
I'm actually already failing here (and Jenkins too):TEST-START | test_ftu_skip_tour.py TestFtu.test_ftu_skip_tour TEST-UNEXPECTED-ERROR | test_ftu_skip_tour.py TestFtu.test_ftu_skip_tour | TimeoutException: TimeoutException: Timed out after 10.2 seconds with message: No languages listed on screen Traceback (most recent call last): File "/Users/mwargers/.virtualenvs/gaia-py-latest/lib/python2.7/site-packages/marionette_client-0.16-py2.7.egg/marionette/marionette_test.py", line 296, in run testMethod() File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_skip_tour.py", line 40, in test_ftu_skip_tour self.wait_for_condition(lambda m: self.ftu.languages_list > 0, message="No languages listed on screen") File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 1122, in wait_for_condition Wait(self.marionette, timeout).until(method, message=message) File "/Users/mwargers/.virtualenvs/gaia-py-latest/lib/python2.7/site-packages/marionette_driver-0.9-py2.7.egg/marionette_driver/wait.py", line 143, in until cause=last_exc) TEST-INFO took 82011ms SUMMARY ------- passed: 0 failed: 1 todo: 0 I'll look at this test.
Assignee: nobody → martijn.martijn
Assignee | ||
Comment 2•9 years ago
|
||
This is suffering from the "is_selected() not working on custom elements" bug, see bug 1113742. The issue in comment 1 is filed as bug 1179891, but I'll just fix it as part of this bug.
Assignee | ||
Comment 3•9 years ago
|
||
Actually, this looks like a real bug. I suspect this is a regression from bug 1176905. This can also be tested manually: - Make sure you have debugging via USB is turned on (ADB at least) - On desktop, open WebIDE, connect to the Flame device and choose the System app. - Open the FTU app - Go to the part where the "Yes! Send data." checkbox is. - On desktop in WebIDE, choose Runtime->Device Settings, then look for debug.performance_data.shared, make sure it reflects the same value as the "Yes! Send data." checkbox. - Now uncheck the "Yes! Send data." checkbox, then reconnect to the Flame device (so the Device settings reading gets refreshed), then look for debug.performance_data.shared and make sure it reflects the same value as the "Yes! Send data." checkbox. --> In that last step, the debug.performance_data.shared setting still is checked in WebIDE, while the "Yes! Send data." checkbox is not checked. The 'id="wifi_show_password"' part in this code at least, doesn't look good (and is certainly a regression from bug 1176905): http://mxr.mozilla.org/gaia/source/apps/ftu/index.html?force=1#601 601 <label id="wifi_show_password" data-l10n-id="sharePerformanceAndUsageData2"></label>
Assignee | ||
Comment 4•9 years ago
|
||
Perhaps this: http://mxr.mozilla.org/gaia/source/apps/ftu/js/ui.js#262 262 this.sharePerformance.addEventListener('click', this); Needs to be using 'change' event now?
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Martijn Wargers [:mwargers] (QA) from comment #4) > Perhaps this: http://mxr.mozilla.org/gaia/source/apps/ftu/js/ui.js#262 > 262 this.sharePerformance.addEventListener('click', this); > Needs to be using 'change' event now? That seems to indeed fix the issue.
Attachment #8629447 -
Flags: review?(kgrandon)
Comment 6•9 years ago
|
||
Comment on attachment 8629447 [details] [review] https://github.com/mozilla-b2g/gaia/pull/30823 Great, thank you so much for fixing this! This is the exact same issue that I fixed before which Sam reviewed, so I think this is ok to land this tiny change.
Flags: needinfo?(kgrandon)
Attachment #8629447 -
Flags: review?(kgrandon) → review+
Comment 7•9 years ago
|
||
In master: https://github.com/mozilla-b2g/gaia/commit/75071a1117605a7ac79c51025caf6ffcfc4dfa95
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•9 years ago
|
||
You're welcome :)
You need to log in
before you can comment on or make changes to this bug.
Description
•