Toni Willberg Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.130 Safari/537.36

Steps to reproduce:

There's no option to change my email address anywhere in bugzilla.mozilla.org



Expected results:

Please instruct how to change the email address, or enable the self-service change if it's disabled by accident.

	Toni Willberg Reporter
	Comment 1 • 9 years ago

After clicking everything in the UI randomly, I figured out user needs to do:
 1) User Profile
 2) click (change) name

Then the next dialog allows changing email address.

Suggestion: move the #2 "change name" link to under the email address and relabel it as "Edit user profile"

	Sebastin Santy [:seban] Assignee
	Comment 2 • 8 years ago

Hi Dylan,

I would like to take up this bug. Can you please instruct on how to go about making changes for bugzilla?

	Dylan Hardison [:dylan] (he/him)
	Comment 3 • 8 years ago

Hi! This would be a change for BMO (as opposed to vanilla bugzilla). The only difficulty here is that getting
a working BMO dev env is a little more complicated than upstream (although this will be changing :-)

For running a copy locally and being able to make changes, I'd recommend following
https://github.com/mozilla-bteam/bmo/blob/master/docker/README.md

As for the process of submitting changes, we're beginning to experiment with github pull requests.
So you can fork https://github.com/mozilla-bteam/bmo, commit some stuff and create a pull request like any
normal github project. We ask that the pull request summary include this Bug id, in the form of 'Bug 1178040'.

I can also tell where to start:

The user profile content is https://github.com/mozilla-bteam/bmo/blob/master/extensions/UserProfile/template/en/default/pages/user_profile.html.tmpl
Moving or adding "change email" next to the email field will probably help.

Maybe the place where the email address is in the top right corner should have a link to the pref page where you can change the email? That template is https://github.com/mozilla-bteam/bmo/blob/master/template/en/default/global/header.html.tmpl

Now, if the problem we want to solve is that https://bugzilla.mozilla.org/userprefs.cgi?tab=account is confusing (as it groups together the password and the email address change things together, and it isn't clear that you can just change one and not the other), that would be a new bug in the vanilla Bugzilla project.

I'm :dylan in the #bmo channel if you run into any other questions.

	Sebastin Santy [:seban] Assignee
	Comment 4 • 8 years ago

I have added a change email next to the email field. IMO it would be better to have a button like "Show" for "Edit Profile". Also the "Preferences" in the header file can be renamed to something like "Edit Profile and Preferences" for better understanding.

	Dylan Hardison [:dylan] (he/him)
	Comment 5 • 8 years ago

Comment on attachment 8767559 [details] [review]
Added "change email"

r=dylan

	Dylan Hardison [:dylan] (he/him)
	Comment 6 • 8 years ago

(In reply to Sebastin Santy [:seban] from comment #4)
> Created attachment 8767559 [details] [review]
> Added "change email"
> 
> I have added a change email next to the email field. IMO it would be better
> to have a button like "Show" for "Edit Profile". Also the "Preferences" in
> the header file can be renamed to something like "Edit Profile and
> Preferences" for better understanding.

Sure! give that a try too.

	Dylan Hardison [:dylan] (he/him)
	Comment 7 • 8 years ago

would you like to work on the more complex changes in a new bug? that way I'll commit this simple change and you can resolve this bug?

	Sebastin Santy [:seban] Assignee
	Comment 8 • 8 years ago

(In reply to Dylan William Hardison [:dylan] from comment #7)
> would you like to work on the more complex changes in a new bug? that way
> I'll commit this simple change and you can resolve this bug?

I would be happy to work for the new bug.

(In reply to Dylan William Hardison [:dylan] from comment #6)
> (In reply to Sebastin Santy [:seban] from comment #4)
> > Created attachment 8767559 [details] [review]
> > Added "change email"
> > 
> > I have added a change email next to the email field. IMO it would be better
> > to have a button like "Show" for "Edit Profile". Also the "Preferences" in
> > the header file can be renamed to something like "Edit Profile and
> > Preferences" for better understanding.
> 
> Sure! give that a try too.

I'll make these changes and then try to squash the pull request commits. But for that, I am still in the process of setting up bugzilla locally (as I would need to look into the placement of the button).

	Dylan Hardison [:dylan] (he/him)
	Comment 10 • 8 years ago

Comment on attachment 8768678 [details] [review]
Edit Profile and Preferences Tabs added

I think this is a good path -- should be about done after you make a few changes (listed in pull request)

	Dylan Hardison [:dylan] (he/him)
	Comment 11 • 8 years ago

Comment on attachment 8768678 [details] [review]
Edit Profile and Preferences Tabs added

r=dylan

	Dylan Hardison [:dylan] (he/him)
	Comment 12 • 8 years ago

I fixed a small nit with the offset of the button when not-logged-in that I didn't notice earlier.

To git@github.com:mozilla-bteam/bmo.git
   bbe5dcd..a446cca  master -> master

	Steve VanSlyck
	Comment 13 • 6 years ago

Still not seeing any way to update my email address.