Closed
Bug 1177740
Opened 9 years ago
Closed 9 years ago
Deploy NSIS 3.0b1 to 2008 build slaves
Categories
(Infrastructure & Operations :: RelOps: Puppet, task)
Infrastructure & Operations
RelOps: Puppet
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: markco, Assigned: markco)
Details
(Whiteboard: [windows])
Attachments
(1 file, 1 obsolete file)
1.80 KB,
patch
|
markco
:
review+
markco
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Assignee: relops → mcornmesser
Whiteboard: [windows]
Assignee | ||
Updated•9 years ago
|
Summary: Deploy NSIS 3.0b1 to 2008 nbuildslaves → Deploy NSIS 3.0b1 to 2008 build slaves
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8627270 -
Flags: review?(dustin)
Comment 2•9 years ago
|
||
Comment on attachment 8627270 [details] [diff] [review] BUG1177740.patch Review of attachment 8627270 [details] [diff] [review]: ----------------------------------------------------------------- looks good otherwise ::: modules/packages/manifests/nsis3_0b1.pp @@ +1,5 @@ > +# Source Code Form is subject to the terms of the Mozilla Public > +# License, v. 2.0. If a copy of the MPL was not distributed with this > +# file, You can obtain one at http://mozilla.org/MPL/2.0/. > + > +# Outlook header API files. Avialable at http://www.microsoft.com/en-us/download/details.aspx?id=12905 I think this comment is left over from copy/paste?
Attachment #8627270 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Removed the unrelated comment. Carrying the r+ forward.
Attachment #8627270 -
Attachment is obsolete: true
Attachment #8627838 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Attachment #8627838 -
Flags: review+ → review?(dustin)
Assignee | ||
Updated•9 years ago
|
Attachment #8627838 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8627838 [details] [diff] [review] BUG1177740.patch https://hg.mozilla.org/build/puppet/rev/0bcd25e190e6
Attachment #8627838 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•