Frédéric Wang (:fredw) Assignee
	Description • 9 years ago

Follow up of bug 744790.

See bug 744790 comment 0 and bug 744790 comment 5.

	Frédéric Wang (:fredw) Assignee
	Comment 4 • 9 years ago

Trying attachment 8667522 [details] with Yura, the layout tables are now indeed rendered with AXGroup objects.

However, this makes nighly crash in accessibilityAttributeValue with the "Attachments" of Bugzilla...

	Frédéric Wang (:fredw) Assignee
	Comment 6 • 9 years ago

> Group: core-security

Sorry, I didn't want to make this a security bug.

	Frédéric Wang (:fredw) Assignee
	Comment 7 • 9 years ago

@Marco Can you please try that one:

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/fred.wang@free.fr-b123129dfc3f/try-macosx64/firefox-44.0a1.en-US.mac.dmg

I verified that the crash no longer happens and that the table elements are now presented as AXGroups. However, I don't know if that's what you meant in bug 744790 comment 5.

	Marco Zehe (:MarcoZ)
	Comment 8 • 9 years ago

Yes, this works like I would expect now.

	alexander :surkov (:asurkov)
	Comment 9 • 9 years ago

Comment on attachment 8667402 [details] [diff] [review]
Patch

Review of attachment 8667402 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +223,5 @@
>  
>    NS_OBJC_END_TRY_ABORT_BLOCK_RETURN(NO);
>  }
>  
> +- (BOOL)isComponentOfLayoutTable

nit: might be nice to name if isLayoutTablePart to make it sync with nsAccessibilityService names

@@ +241,5 @@
> +      table = accWrap->AsTableCell()->Table();
> +    }
> +    if (table && table->IsProbablyLayoutTable()) {
> +      return true;
> +    }

nit: return false; and no else

@@ +939,5 @@
>    }
>  
> +  if ([self isComponentOfLayoutTable]) {
> +    return NSAccessibilityGroupRole;
> +  }

I wish we had something nicer than checking table stuff for each role.

	Frédéric Wang (:fredw) Assignee
	Comment 12 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45bd8cd8985e

(In reply to alexander :surkov from comment #9)
> I wish we had something nicer than checking table stuff for each role.

This will be handled in bug 1178272.

	Frédéric Wang (:fredw) Assignee
	Comment 13 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45bd8cd8985e

	Pulsebot
	Comment 14 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/96f19a715e61

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 15 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/96f19a715e61