Marco Zehe (:MarcoZ) Assignee
	Description • 9 years ago

This is a very recent regression: I noticed it while testing the try build for bug 744790, but also in the 2015-06-24 Nightly build. Other control types such as text boxes, check boxes, buttons etc. work, but for links, VoiceOver recently started to say "main", and it also speaks the word "main" far more often than it used to.

If you have an idea where this comes from, fine. If not, I'll find the regression range later. But I know that recently, this still worked fine, when I was testing the MathML exposure stuff. So this can't be more than 1 or 2 weeks old.

Steps are simple: Open any page that has links and navigate through with VoiceOver+RightArrow.

	Marco Zehe (:MarcoZ) Assignee
	Comment 1 • 9 years ago

It was already broken on the 2015-06-19 nightly build, where bug 1150510 was fixed. The crashes prevent me from finding a regression range from before that, sorry! I'm afraid you'll have to debug this. :(

	Marco Zehe (:MarcoZ) Assignee
	Comment 2 • 9 years ago

This fixes the problem. And no, I don't know why. Just followed a hunch, and it worked.

	Marco Zehe (:MarcoZ) Assignee
	Comment 3 • 9 years ago

This fixes the problem, and landmarks etc. still work.

	alexander :surkov (:asurkov)
	Comment 4 • 9 years ago

Comment on attachment 8626391 [details] [diff] [review]
Only search for the sub role's mapping if subrole isn't NIL

Review of attachment 8626391 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +779,5 @@
>      return utils::LocalizedString(NS_LITERAL_STRING("htmlContent"));
>  
>    NSString* subrole = [self subrole];
>  
> +if (subrole) {

nit: pls indent it

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/7214ce01cee5

	Carsten Book [:Tomcat]
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/7214ce01cee5

	Marco Zehe (:MarcoZ) Assignee
	Comment 7 • 9 years ago

Comment on attachment 8626391 [details] [diff] [review]
Only search for the sub role's mapping if subrole isn't NIL

Approval Request Comment
[Feature/regressing bug #]: bug 1137714, only uncovered after fix for bug 1150510
[User impact if declined]: Links and other elements will not be properly identified by VoiceOver on OS X.
[Describe test coverage new/current, TreeHerder]: Manual testing, is in Central.
[Risks and why]: No risk, basically a null check.
[String/UUID change made/needed]: None.

	Sylvestre Ledru [:Sylvestre]
	Comment 8 • 9 years ago

Comment on attachment 8626391 [details] [diff] [review]
Only search for the sub role's mapping if subrole isn't NIL

Not sure that it is the correct patch in bugzilla (indent issue) but I am sure that the sheriff won't use it.

Anyway, taking it to aurora as we want to improve the accessibility but not in beta (or release) as 39 is going to go live next week.

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/e9f673332255