Closed Bug 1176973 Opened 9 years ago Closed 9 years ago

[NSAccessibility] Expose attribute AXMathLineThickness for fraction bars

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox41 --- affected
firefox42 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

Details

Attachments

(2 files, 1 obsolete file)

WebKit exposes the attribute AXMathLineThickness that allows to present the thickness of the fraction bar. I'm not sure how it is used by VoiceOver, but it's at least important to e.g. distinguish between combination (linethickness="0px") or Legendre symbol (with default linethickness).
Component: MathML → Disability Access APIs
Attached patch Patch (obsolete) — Splinter Review
Although WebKit exposes this attribute, it does not seem to be used by VoiceOver (https://bugs.webkit.org/show_bug.cgi?id=146454) so we can not really test it. Also, the accessibility inspector does not seem to display all attributes for me, so I add to test the code using some debug logging...
Assignee: nobody → fred.wang
Status: NEW → ASSIGNED
Attachment #8628700 - Flags: review?(mzehe)
Comment on attachment 8628700 [details] [diff] [review]
Patch

Review of attachment 8628700 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +436,5 @@
> +      nsAccUtils::GetAccAttr(attributes, nsGkAtoms::linethickness_, thickness);
> +      double value = 1.0;
> +      if (!thickness.IsEmpty())
> +	value = PR_strtod(NS_LossyConvertUTF16toASCII(thickness).get(),
> +			  nullptr);

Nit: Please convert tabs to spaces.
Attachment #8628700 - Flags: review?(mzehe) → review+
Attached patch Patch V2Splinter Review
Attachment #8628700 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/76b1bf603f53
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: