Anne (:annevk) Reporter
	Description • 9 years ago

This would significantly simplify the complexity of the object and not really reduce the functionality.

	Anne (:annevk) Reporter
	Comment 1 • 9 years ago

(I will update the specification if this is successful, as far as I know we're still the only ones implementing this.)

	Anne (:annevk) Reporter
	Comment 2 • 9 years ago

To clarify, the reason the specification is not changed is because this rather simplifies URLSearchParams as the relationship to URL objects becomes 1:1. I'd like to make sure we can land this without issue as otherwise I end up changing the specification twice.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 4 • 9 years ago

Anne, is the idea then to have something like .clear() in URLSearchParams?
Though, I guess one can always use url.search = "";

	Anne (:annevk) Reporter
	Comment 5 • 9 years ago

Yeah, we could add new methods later. Need to figure out what kind of methods make sense for multimap objects. Note that FormData/URLSearchParams/Headers are extremely close in terms of API.

	Anne (:annevk) Reporter
	Comment 7 • 9 years ago

Comment on attachment 8625778 [details] [diff] [review]
usp3.patch

Review of attachment 8625778 [details] [diff] [review]:
-----------------------------------------------------------------

Please lose the indentation so that the word "attribute" is aligned with the lines before. Also, this should be a new URLUtilsSearchParams interface, no?

	Pulsebot
	Comment 9 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c93813baadc
https://hg.mozilla.org/integration/mozilla-inbound/rev/44002ebe4e2c

	Andrea Marchesini [:baku] Assignee
	Comment 10 • 9 years ago

Comment on attachment 8625786 [details] [diff] [review]
usp3.patch

I received a r+ from annevk in 'real life'.

	Carsten Book [:Tomcat]
	Comment 11 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/9c93813baadc
https://hg.mozilla.org/mozilla-central/rev/44002ebe4e2c

	Anne (:annevk) Reporter
	Comment 12 • 9 years ago

https://www.w3.org/Bugs/Public/show_bug.cgi?id=27596 will fix this specification-wise.

	Kohei Yoshino [:kohei]
	Comment 13 • 9 years ago

It breaks my BzDeck app :(

https://github.com/bzdeck/bzdeck/blob/master/webroot/static/scripts/controllers/base.js#L21

Why searchParams is readonly even on new URL?

	Anne (:annevk) Reporter
	Comment 14 • 9 years ago

> Why searchParams is readonly even on new URL?

Because 1:1 is much better than 1:M and you can simply assign to .search instead.

	Kohei Yoshino [:kohei]
	Comment 15 • 9 years ago

Thanks, url.search works for me. 
https://github.com/bzdeck/bzdeck/commit/c0841f7f0bfe17fac71b606be6b3777049aea6dc

Documented on the site compat doc.
https://developer.mozilla.org/en-US/Firefox/Releases/41/Site_Compatibility#DOM