Closed Bug 1174437 Opened 9 years ago Closed 9 years ago

[e10s] GCLI media emulate command does not work with e10s

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(e10s+, firefox41 affected, firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
e10s + ---
firefox41 --- affected
firefox44 --- fixed

People

(Reporter: callahad, Assigned: pbro)

References

Details

(Keywords: DevAdvocacy)

Attachments

(1 file)

Bug_1174437_-_Run_the_gcli_media_emulation_command.diff
2.60 KB, patch
jwalker
: review+
Details | Diff | Splinter Review 
GCLI `media emulate print` fails with "this.docshell is null" when run under e10s
The media emulation command must run in content, so I changed the runAt property to "server" and fixed the way the contentViewer was retrieved from the window.
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Attachment #8667149 - Flags: review?(jwalker)
Comment on attachment 8667149 [details] [diff] [review]
Bug_1174437_-_Run_the_gcli_media_emulation_command.diff

Review of attachment 8667149 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a reason to use 'let' in place of 'const'?
Attachment #8667149 - Flags: review?(jwalker) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b75ac52dab6c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
I have reproduced this bug with Firefox 41.0a1 (Build: 20150613030206)on 
windows 8.1 pro 64-bit with the instructions from comment 0 .

Verified as fixed with Latest Firefox Aurora 44.0a2 (Build ID: 20151105004045)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0
QA Whiteboard: [bugday-20151104]
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: