Joanmarie Diggs Reporter
	Description • 9 years ago

Steps to reproduce:
1. Launch Thunderbird or Firefox
2. Launch Accerciser and select an object which implements AtkText
3. In Accerciser's iPython console, get the attribute run for an offset

If you look at the bg-color and fg-color values (below), you'll see that the open paren and first digit are missing (compare to background-color and color).

For anyone wondering about the duplicates, Gecko used to expose attributes using their own names and not the names expected in ATK. Now it exposes the names expected by ATK (thanks!!), along with the old names for backwards compatibility. I discovered this bug by trying to rip out the special handling for Gecko attributes from Orca. Suddenly things became cyan. ;)

Sample output:

In [1]: acc.queryText().getAttributeRun(0)
Out[2]: 
[['font-style:normal',
  'background-color:rgb(255, 255, 255)',
  'weight:400',
  'size:11',
  'font-size:11pt',
  'language:en',
  'fg-color:1, 51, 51)',
  'font-weight:400',
  'font-family:Open Sans',
  'family-name:Open Sans',
  'bg-color:55, 255, 255)',
  'text-position:baseline',
  'color:rgb(51, 51, 51)'],
 0,
 8]

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 2 • 9 years ago

Comment on attachment 8621787 [details] [diff] [review]
format gecko to atk attribute conversion for fg-color and bg-color correctly

Review of attachment 8621787 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/nsMaiInterfaceText.cpp
@@ +31,5 @@
>    const char* atkName = nullptr;
>    nsAutoString atkValue;
>    if (aName.EqualsLiteral("color")) {
>      // The format of the atk attribute is r,g,b and the gecko one is
>      // rgb(r,g,b).

Can you change this old comment to add the spaces you mentioned in IRC so we can remember later why we are stripping whitespace? So above line would say // rgb(r, g, b) instead of // rgb(r,g,b)

	Lorien Hu (:lsocks) Assignee
	Comment 3 • 9 years ago

carry r=davidb

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/68d68a7b9150

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/68d68a7b9150