Markus Stange [:mstange] Assignee
	Description • 9 years ago

This bug tracks the work that needs to be done before we can set the pref canvas.filters.enabled to true by default.

	Florian Scholz (Open Web Docs)
	Comment 1 • 8 years ago

This is now enabled by default in Chrome 52
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Jhwj8QAYaFY
https://www.chromestatus.com/features/6701649301078016

	Tobias Schneider [:tobytailor]
	Comment 2 • 8 years ago

Turn on the lights!

	Tobias Schneider [:tobytailor]
	Comment 3 • 8 years ago

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=33c6e86e558d

	Markus Stange [:mstange] Assignee
	Comment 4 • 8 years ago

Comment on attachment 8758384 [details] [diff] [review]
Flip canvas.filters.enabled pref

Review of attachment 8758384 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

	Marcia Knous [:marcia]
	Comment 5 • 8 years ago

Markus/Tobias - Do you want to land this on mozcentral and then nominate it to be release noted?

	Tobias Schneider [:tobytailor]
	Comment 6 • 8 years ago

Yes!

	Tobias Schneider [:tobytailor]
	Comment 7 • 8 years ago

New try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bee9a727d4a

	Pulsebot
	Comment 8 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/daf8583252b2
Enable canvas CSS/SVG filters by default. r=mstange

	Carsten Book [:Tomcat]
	Comment 9 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/daf8583252b2

	Florian Scholz (Open Web Docs)
	Comment 10 • 8 years ago

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Dev-docs:
https://developer.mozilla.org/en-US/Firefox/Releases/49#Canvas
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/filter

Also adding relnote request as per comment 5:

Release Note Request (optional, but appreciated)
[Why is this notable]: CSS filters are now available to canvas as well
[Suggested wording]: The Canvas2D filter property has been implemented. It provides filter effects like blurring or gray-scaling similar to the CSS filter property.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/filter

	Sylvestre Ledru [:Sylvestre]
	Comment 11 • 8 years ago

I think that the note on MDN is enough. Please need info me if you disagree

	ishmael.ahmed
	Comment 12 • 8 years ago

I think this fix effect ctx.shadowBlur ?

	ishmael.ahmed
	Comment 13 • 8 years ago

I have been using a mixture of globalAlpha, shadowColor, and shadowBlur to blur text in my canvas elements. Since the release this technique is now failing, would the implementation of the blur filter be effecting it?

	Markus Stange [:mstange] Assignee
	Comment 14 • 8 years ago

It's possible that the interaction with the filter code has broken something. Can you please file a new bug and attach a minimal testcase?

	ishmael.ahmed
	Comment 15 • 8 years ago

Will do

	ishmael.ahmed
	Comment 16 • 8 years ago

I found Bug 1306027, and added a link to my example[https://jsfiddle.net/ishmael_readingplus/hag1tc99/] there.