Closed Bug 1172538 Opened 9 years ago Closed 9 years ago

make sure a document has an IPC actor before shutting it down

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 --- unaffected
firefox40 --- unaffected
firefox41 + fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

Details

(Keywords: regression, topcrash)

Crash Data

Attachments

(1 file)

If a document is shutdown before ever being bound to a parent document it
doesn't have an associated IPC actor, so we shouldn't try and shut one down.
If a document is shutdown before ever being bound to a parent document it
doesn't have an associated IPC actor, so we shouldn't try and shut one down.
Attachment #8616721 - Flags: review?(lorien)
Attachment #8616721 - Flags: review?(dbolter)
Comment on attachment 8616721 [details] [diff] [review]
make sure a document has an IPC actor before shutting it down

Review of attachment 8616721 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/DocAccessible.cpp
@@ +454,5 @@
>  
>    mChildDocuments.Clear();
>  
>    // XXX thinking about ordering?
> +  if (mIPCDoc && IPCAccessibilityActive()) {

I guess we don't need the second check, in live review you suggested maybe just making it an assert.
Attachment #8616721 - Flags: review?(dbolter) → review+
Attachment #8616721 - Flags: review?(lorien)
Attachment #8616721 - Flags: review+
Assignee: nobody → tbsaunde+mozbugs
https://hg.mozilla.org/mozilla-central/rev/076f168c0a91
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Should this fix be in 20150610030209, or do I need to wait for another build?
(In reply to Shawn Wilsher :sdwilsh from comment #6)
> Should this fix be in 20150610030209, or do I need to wait for another build?

Wait for today's nightly, judging by the timestamp you posted and comment #4 .
Crash Signature: [@ mozilla::a11y::DocAccessible::Shutdown()]
This is a huge top crash in nightly only, so it seems like it must be a regression.
Keywords: topcrash
Tracking in 41 because it is a top crash, and untracked its duplicate.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: