Closed
Bug 1172525
Opened 9 years ago
Closed 9 years ago
rework forwarding events to the parent process
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
Details
Attachments
(1 file)
7.92 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8616683 -
Flags: review?(lorien)
Attachment #8616683 -
Flags: review?(dbolter)
Comment 2•9 years ago
|
||
Comment on attachment 8616683 [details] [diff] [review] rework forwarding events to the parent process Review of attachment 8616683 [details] [diff] [review]: ----------------------------------------------------------------- as discussed, potentially call mDocument might be null by mDocument->ShutdownChildrenInSubtree(event->mAccessible) since we moved the call to HandleAcc event before this call
Attachment #8616683 -
Flags: review?(lorien) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to lsocks from comment #2) > Comment on attachment 8616683 [details] [diff] [review] > rework forwarding events to the parent process > > Review of attachment 8616683 [details] [diff] [review]: > ----------------------------------------------------------------- > > as discussed, potentially call mDocument might be null by > mDocument->ShutdownChildrenInSubtree(event->mAccessible) since we moved the > call to HandleAcc event before this call actually I didn't move HandleAccEvent, I moved some other stuff into HandleAccEvent. So that is a separate issue.
Updated•9 years ago
|
Assignee: nobody → tbsaunde+mozbugs
Updated•9 years ago
|
Attachment #8616683 -
Flags: review?(dbolter)
Comment 5•9 years ago
|
||
Backed out for e10s test_selectioncarets2.py failures. https://treeherder.mozilla.org/logviewer.html#?job_id=10672799&repo=mozilla-inbound
https://hg.mozilla.org/mozilla-central/rev/ff93192ea30e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•