Closed Bug 1172525 Opened 9 years ago Closed 9 years ago

rework forwarding events to the parent process

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

References

Details

Attachments

(1 file)

      No description provided.
Attachment #8616683 - Flags: review?(lorien)
Attachment #8616683 - Flags: review?(dbolter)
Comment on attachment 8616683 [details] [diff] [review]
rework forwarding events to the parent process

Review of attachment 8616683 [details] [diff] [review]:
-----------------------------------------------------------------

as discussed, potentially call mDocument might be null by mDocument->ShutdownChildrenInSubtree(event->mAccessible) since we moved the call to HandleAcc event before this call
Attachment #8616683 - Flags: review?(lorien) → review+
(In reply to lsocks from comment #2)
> Comment on attachment 8616683 [details] [diff] [review]
> rework forwarding events to the parent process
> 
> Review of attachment 8616683 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> as discussed, potentially call mDocument might be null by
> mDocument->ShutdownChildrenInSubtree(event->mAccessible) since we moved the
> call to HandleAcc event before this call

actually I didn't move HandleAccEvent, I moved some other stuff into HandleAccEvent.  So that is a separate issue.
Assignee: nobody → tbsaunde+mozbugs
https://hg.mozilla.org/mozilla-central/rev/ff93192ea30e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Depends on: 1185726
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: