Martijn Wargers (dead) Assignee
	Description • 9 years ago

Running this test causes a failure on my device, currently:

TEST-START | test_clock_create_new_alarm.py TestClockCreateNewAlarm.test_clock_create_new_alarm
TEST-UNEXPECTED-ERROR | test_clock_create_new_alarm.py TestClockCreateNewAlarm.test_clock_create_new_alarm | TimeoutException: TimeoutException: Timed out after 10.0 seconds


Traceback (most recent call last):
  File "/Users/mwargers/.virtualenvs/gaia-py-latest/lib/python2.7/site-packages/marionette_client-0.13-py2.7.egg/marionette/marionette_test.py", line 296, in run
    testMethod()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/tests/functional/clock/test_clock_create_new_alarm.py", line 72, in test_clock_create_new_alarm
    time_picker.add_minute()
  File "/Users/mwargers/B2G/gaia_clean/tests/python/gaia-ui-tests/gaiatest/apps/system/regions/time_picker.py", line 52, in add_minute
    Wait(self.marionette).until(lambda m: self.minute != minute)
  File "/Users/mwargers/.virtualenvs/gaia-py-latest/lib/python2.7/site-packages/marionette_driver-0.7-py2.7.egg/marionette_driver/wait.py", line 143, in until
    cause=last_exc)
TEST-INFO took 112424ms

	Martijn Wargers (dead) Assignee
	Comment 1 • 9 years ago

This is also seen on Jenkins smoke, btw. See the screenshot. As you can see, the minute is a little bit moved, at least.

	Martijn Wargers (dead) Assignee
	Comment 2 • 9 years ago

There are some issues with the add_minute() method, as described by the bugs in there: http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/system/regions/time_picker.py#45

	Martijn Wargers (dead) Assignee
	Comment 3 • 9 years ago

This makes the test pass. I don't really know of a better way of fixing this. If you have a better idea, let me know.

	Johan Lorenzo [:jlorenzo]
	Comment 4 • 9 years ago

Comment on attachment 8616492 [details] [review]
pull request

This part of the code have been prone to hacks as far as I remember. I don't see a better way to deal with it. However, John is struggling on this particular issue on MarionetteJS. He might have a solution. Let's hear his feedback once he gets back.

	No-Jun Park [:njpark]
	Comment 5 • 9 years ago

Comment on attachment 8616492 [details] [review]
pull request

I also have the feeling that they might change the code to break the test later, but at the moment this is a working fix, r+.

	Martijn Wargers (dead) Assignee
	Comment 6 • 9 years ago

Merged this: https://github.com/mozilla-b2g/gaia/commit/16f363aacab1ab3dd91241d6ce6e09b40a8052c0
If John has good ideas on to improve this, I will.