Closed
Bug 1172053
Opened 9 years ago
Closed 9 years ago
use malloc a little less when dispatching atk events
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla41
Tracking | Status | |
---|---|---|
firefox41 | --- | fixed |
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(3 files)
3.00 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
3.05 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
3.01 KB,
patch
|
lsocks
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8616094 -
Flags: review?(lorien)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8616096 -
Flags: review?(lorien)
Comment 3•9 years ago
|
||
Comment on attachment 8616094 [details] [diff] [review] don't call malloc in FireAtkShowHideEvent Review of attachment 8616094 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/atk/AccessibleWrap.cpp @@ +1504,5 @@ > AtkObject *parentObject = getParentCB(aObject); > NS_ENSURE_STATE(parentObject); > > bool isFromUserInput = aEvent->IsFromUserInput(); > + const char *signal_name = kMutationStrings[!!isFromUserInput][!aIsAdded]; The double negation here isn't necessary, bools are guaranteed to be converted to 0/1.
Attachment #8616094 -
Flags: review?(lorien) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8616096 [details] [diff] [review] don't malloc the signal name in FireAtkTextChangedEvent Review of attachment 8616096 [details] [diff] [review]: ----------------------------------------------------------------- Also, just noticed this, but if you wanted to be consistent in the order of the user and system arrays, they're in the opposite order in the other patch. ::: accessible/atk/AccessibleWrap.cpp @@ +1485,5 @@ > // XXX remove this code and the gHaveNewTextSignals check when we can > // stop supporting old atk since it doesn't really work anyway > // see bug 619002 > + const char* signal_name = > + oldTextChangeStrings[!!isFromUserInput][!!isInserted]; double negation isn't needed here @@ +1491,5 @@ > } else { > nsAutoString text; > event->GetModifiedText(text); > + const char* signal_name = > + textChangedStrings[!!isFromUserInput][!!isInserted]; same
Attachment #8616096 -
Flags: review?(lorien) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8620412 -
Flags: review?(lorien)
Updated•9 years ago
|
Attachment #8620412 -
Flags: review?(lorien) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/e61c7faffb26 https://hg.mozilla.org/integration/mozilla-inbound/rev/37297b333f42
https://hg.mozilla.org/mozilla-central/rev/e61c7faffb26 https://hg.mozilla.org/mozilla-central/rev/37297b333f42
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Updated•9 years ago
|
Assignee: nobody → tbsaunde+mozbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•