Trevor Saunders (:tbsaunde) Assignee
	Description • 9 years ago

      No description provided.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 3 • 9 years ago

Comment on attachment 8614109 [details] [diff] [review]
switch to sending __delete__ from the parent instead of the child

Review of attachment 8614109 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks for IRC'ing. (__delete__ is still a bit of mysterious to me)

::: accessible/ipc/DocAccessibleChild.h
@@ +33,5 @@
>    ~DocAccessibleChild()
>    {
> +    MOZ_ASSERT(!mDoc);
> +    if (mDoc)
> +      mDoc->SetIPCDoc(nullptr);

nit: If you have any hunches why we need this maybe add a comment?

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 5 • 9 years ago

Comment on attachment 8615992 [details] [diff] [review]
only send __delete__ from DocAccessibleParent if the tab isn't destroyed

> DocAccessibleParent::RecvShutdown()
> {
>   Destroy();
>+
>+  if (!static_cast<dom::TabParent*>(Manager())->IsDestroyed()) {
>   return PDocAccessibleParent::Send__delete__(this);
Missing 2 space indentation for the return

	Pulsebot
	Comment 6 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/33283f55d8ef
https://hg.mozilla.org/integration/mozilla-inbound/rev/78fc82c0601a

	Carsten Book [:Tomcat]
	Comment 7 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/33283f55d8ef
https://hg.mozilla.org/mozilla-central/rev/78fc82c0601a