Marco Bonardo [:mak] (Away Apr 25 - May 5) Assignee
	Description • 9 years ago

It's that time again!
For now I'd keep it under #if defined(NIGHTLY_BUILD)

	Dave Townsend [:mossop]
	Comment 1 • 9 years ago

(In reply to Marco Bonardo [::mak] from comment #0)
> It's that time again!
> For now I'd keep it under #if defined(NIGHTLY_BUILD)

Why? Seems like we have the regressions we know about under control and we really need this for search suggestions which we want to ship. If we find enough problems that we want to turn this off on aurora then we still can but I'd prefer the default assumption to be that we're shipping this.

	Marco Bonardo [:mak] (Away Apr 25 - May 5) Assignee
	Comment 2 • 9 years ago

I was probably overzealous. Removing the "if defined" in Aurora is simple, it's not as simple to disable things on the merge day, when needed. But yeah, I hope we won't need that.

	Marco Bonardo [:mak] (Away Apr 25 - May 5) Assignee
	Comment 3 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f26e5abd4a6

	Marco Bonardo [:mak] (Away Apr 25 - May 5) Assignee
	Comment 4 • 9 years ago

Comment on attachment 8612176 [details] [diff] [review]
patch v1

I'd say Try is happy enough for this to land

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/6968dac17cdf

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/6968dac17cdf

	Andrei Vaida [:avaida]
	Comment 7 • 9 years ago

This is covered by the regular Regression Testing performed on each of the dependencies.