Closed Bug 1165567 Opened 9 years ago Closed 9 years ago

Implement AWS & DataCenter network settings for 2008 in puppett

Categories

(Infrastructure & Operations :: RelOps: Puppet, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: q, Assigned: markco)

References

Details

Attachments

(2 files)

      No description provided.
Assignee: relops → mcornmesser
Depends on: 1165314
Component: RelOps → RelOps: Puppet
QA Contact: arich → dustin
Summary: Implement AWS network settings for 2008 in puppett → Implement AWS & DataCenter network settings for 2008 in puppett
Attached patch BUG1165567.patchSplinter Review
Some details on the patch. It consists mainly of 2 different parts . The first one which is the registry changes, and those are straight forward. 

The other part is made up the netsh commands. These were a bit complicated in implementing. When Puppet runs these commands directly, they are ran in a 32 bit context. In this context the commands fail. To work around this, the netsh commands are concatted into a bat file, and it is now being executed through a schedule task without a predetermined  trigger. Puppet executed the schedule task through an exec resource. To further complicate it, failures from the schedule task will not pass back to Puppet. To work around this the bat  file redirects any failures into "C:\ProgramData\PuppetLabs\puppet\var\log\\netsh_error.log". The redirected info includes the command and exit code.  Another bat file is set to be executed by Puppet to check for the existence of the log file.  If the file does not exists then it is all good. The concatted bat file will del the log file on each refresh.
Attachment #8621083 - Flags: review?(winter2718)
With this configuration, tested transfer speeds from the datacenter to S3. These speeds were in the range of 42 -47 MB/sec.
Comment on attachment 8621083 [details] [diff] [review]
BUG1165567.patch

+ with one exception: is it really necessary for SchTsk_netsh.xml.erb to be a template? I didn't see a variable.

I prefer files over templates what possible, just for the sake of signaling to future users that there aren't any variables to hunt for.
Comment on attachment 8621083 [details] [diff] [review]
BUG1165567.patch

^^ See comment above for caveat.
Attachment #8621083 - Flags: review?(winter2718) → review+
Made a few changes. Removed a redundant require attribute from exec SchTsk_netsh.

Took another look at the template. Replaced the direct call to C:\etc\network_tweak.bat with a variable since it was being reference in multiple locations across multiple files.
Attachment #8621877 - Flags: review?(winter2718)
Comment on attachment 8621877 [details] [diff] [review]
BUG1165567-2.patch

Review of attachment 8621877 [details] [diff] [review]:
-----------------------------------------------------------------

:+1
Attachment #8621877 - Flags: review?(winter2718) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: