Closed Bug 1164780 Opened 9 years ago Closed 9 years ago

updating an attachment with pre-existing review requests shouldn't enforce the "last logged in to bugzilla" limit

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file)

updating an attachment with pre-existing review requests shouldn't enforce the "last logged in to bugzilla" limit.


right now if you edit an attachment that has an existing review directed at someone who hasn't logged into bugzilla, you're unable to save any changes to that attachment.

the restriction imposed by bug 751862 should only impact new requests, not existing ones.
Attached patch 1164780_1.patchSplinter Review
- perform review checks on added flags instead of all flags
Attachment #8605706 - Flags: review?(dkl)
Comment on attachment 8605706 [details] [diff] [review]
1164780_1.patch

Review of attachment 8605706 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8605706 - Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   9ed5276..4bc64fd  master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Extensions: Review → Extensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: