Trevor Saunders (:tbsaunde) Assignee
	Description • 9 years ago

      No description provided.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 2 • 9 years ago

Comment on attachment 8604868 [details] [diff] [review]
emit a few more events on proxied accessibles for atk

Review of attachment 8604868 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe something more descriptive for checkin like "Emit a some document and menupopup events on proxied accessibles for atk" would be lovelier.

::: accessible/atk/AccessibleWrap.cpp
@@ +1354,5 @@
>  {
>    AtkObject* wrapper = GetWrapperFor(aTarget);
> +
> +  switch (aEventType) {
> +  case nsIAccessibleEvent::EVENT_FOCUS:

nit: this whole switch body should be indented 2 more spaces.

	Trevor Saunders (:tbsaunde) Assignee
	Comment 3 • 9 years ago

> ::: accessible/atk/AccessibleWrap.cpp
> @@ +1354,5 @@
> >  {
> >    AtkObject* wrapper = GetWrapperFor(aTarget);
> > +
> > +  switch (aEventType) {
> > +  case nsIAccessibleEvent::EVENT_FOCUS:
> 
> nit: this whole switch body should be indented 2 more spaces.

that file doesn't seem to agree with itself on if case labels should be indented or not, so it wasn't totally unintentional.

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/06b840460921

	Phil Ringnalda (:philor)
	Comment 5 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/06b840460921