(no longer active) Reporter
	Description • 9 years ago

We should probably return false for now for paste as opposed to throwing when IsEditingOnAfterFlush() returns false.

	Hallvord R. M. Steen [:hallvors]
	Comment 1 • 9 years ago

While you're looking at and thinking of this, comments on the (feas|desir)ability of https://github.com/w3c/clipboard-apis/issues/4 would be very welcome ;)

	(no longer active) Reporter
	Comment 2 • 9 years ago

(In reply to Hallvord R. M. Steen [:hallvors] from comment #1)
> While you're looking at and thinking of this, comments on the
> (feas|desir)ability of https://github.com/w3c/clipboard-apis/issues/4 would
> be very welcome ;)

See bug 596764.  :-)

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 5 • 9 years ago

Acknowledge now-failing browserscope tests

	(no longer active) Reporter
	Comment 6 • 9 years ago

Comment on attachment 8604327 [details] [diff] [review]
Always return true from document.queryCommandEnabled('cut'/'copy')

Review of attachment 8604327 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/tests/test_bug408231.html
@@ +25,2 @@
>        ["createlink", "true"],
> +      ["cut", "true"],

Can you please uncomment and fix the test for paste further down this array?

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 7 • 9 years ago

Un-commented and fixed queryCommandEnabled() test for 'paste'.

The other tests for paste aren't fixed by this patch (they throw).

	Hallvord R. M. Steen [:hallvors]
	Comment 8 • 9 years ago

One moment.. did we consider returning "true" only in a thread that's user-triggered (i.e. allowed to open a popup) and "false" otherwise?

	(no longer active) Reporter
	Comment 9 • 9 years ago

(In reply to Hallvord R. M. Steen [:hallvors] from comment #8)
> One moment.. did we consider returning "true" only in a thread that's
> user-triggered (i.e. allowed to open a popup) and "false" otherwise?

Oh, thanks for noticing this.  Yes, we should definitely return false when we are not handling the user input.  Michael, do you mind making that change, please?

	(no longer active) Reporter
	Comment 10 • 9 years ago

Comment on attachment 8605330 [details] [diff] [review]
Always return true from document.queryCommandEnabled('cut'/'copy')

r- as per comment 9.

	Hallvord R. M. Steen [:hallvors]
	Comment 11 • 9 years ago

http://jsfiddle.net/213ov2ah/ tests queryCommandEnabled() for copy and cut - non-user-initiated and user-initiated.

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 12 • 9 years ago

New patch which now only returns true when in privileged or user-initiated code.

New try in progress: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b6e1e3067e6

	Pulsebot
	Comment 13 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0431f570160d

	Carsten Book [:Tomcat]
	Comment 14 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0431f570160d

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 15 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/0431f570160d

	Jean-Yves Perrier [:teoli]
	Comment 16 • 9 years ago

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported
and
https://developer.mozilla.org/en-US/Firefox/Releases/41#Interfaces.2FAPIs.2FDOM