Neil Deakin Reporter
	Description • 9 years ago

These events were left in for compatibility. However it's been long enough and we should just remove these events in favour of the standard event names.

draggesture -> dragstart
dragdrop -> drop

dragexit should be left as is since the standard dragleave event fires after the dragenter event and is less useful.

This involves:
 1. Removing the NS_DRAGDROP_GESTURE and NS_DRAGDROP_DRAGDROP constants from BasicEvents.h
 2. Remove any usage of these event name constants.
 3. Remove the code that fires these events from EventStateManager.cpp
 4. Convert or remove any existing usage of draggesture and dragdrop event listeners
 5. Remove toolkit/content/nsDragAndDrop.js

A quick glance suggested there are no usage in Firefox, however there are some in Seamonkey/Thunderbird. These should be converted over, but that doesn't need to be done here.

	Chirag Bhatia
	Comment 1 • 9 years ago

Hi Neil,

I can work on this bug. Is there anything I need to test after making my changes in the code?

	Neil Deakin Reporter
	Comment 2 • 9 years ago

Hi, thanks for taking this bug. As far as I know, Firefox doesn't use the events so everything should just work there When you have a patch, we can run through our test suites (try server) just to be sure, and, of course, just run Firefox and try some basic drag and drop operations.

We'll want to give a heads up to Thunderbird and Seamonkey and addon developers with a message describing the change since they may still be dependent on these events.

	Chirag Bhatia
	Comment 3 • 9 years ago

Hi Neil,

I've made the changes that you asked. Unfortunately, I think I broke the drag and drop functionality within my build with these changes (tried on bookmarks and links on web pages).

There are multiple changes (attached), I hope I've done them right. Would appreciate your help in figuring out what's breaking the drag-drop functionality in my build.

	Neil Deakin Reporter
	Comment 4 • 9 years ago

Great! I'll take a look at the patch and see if I can see anything that stands out that would cause the issue you are seeing.

	Neil Deakin Reporter
	Comment 5 • 9 years ago

Comment on attachment 8610719 [details] [diff] [review]
1162050.patch

>diff --git a/dom/events/EventStateManager.cpp b/dom/events/EventStateManager.cpp
>   }
>-  case NS_DRAGDROP_GESTURE:
>-    if (Prefs::ClickHoldContextMenu()) {
>-      // an external drag gesture event came in, not generated internally
>-      // by Gecko. Make sure we get rid of the click-hold timer.
>-      KillClickHoldTimer();
>-    }
>-    break;

I think this needs to be changed to NS_DRAGDROP_START, but I think this is an edge case that doesn't happen in practice.
 

>-      WidgetDragEvent gestureEvent(aEvent->mFlags.mIsTrusted,
>-                                   NS_DRAGDROP_GESTURE, widget);
>-      FillInEventFromGestureDown(&gestureEvent);
>-
>-      startEvent.dataTransfer = gestureEvent.dataTransfer = dataTransfer;
>-      startEvent.inputSource = gestureEvent.inputSource = aEvent->inputSource;
>-

This is likely the source of the problems you are seeing. You want to assign the values to the properties of startEvent, but remove the gestureEvent parts.


-      // Dispatch both the dragstart and draggesture events to the DOM. For
+      // Dispatch both the dragstart event to the DOM. For
       // elements in an editor, only fire the draggesture event so that the
       // editor code can handle it but content doesn't see a dragstart.

We should be able to remove the second sentence here that still refers to draggesture. That comment refers to code that no longer exists.


>       if (status != nsEventStatus_eConsumeNoDefault) {
>-        status = nsEventStatus_eIgnore;
>-        EventDispatcher::Dispatch(targetContent, aPresContext, &gestureEvent,
>-                                  nullptr, &status);
>-        event = &gestureEvent;
>+        status = nsEventStatus_eIgnore;        
>       }

You'll also want to remove this whole block. The status is being reset here only because we need to fire both events. Now that only one event is fired, we can leave the status as is.


>-  case NS_DRAGDROP_DROP:
>-    {
>-      // now fire the dragdrop event, for compatibility with XUL
>-      if (mCurrentTarget && nsEventStatus_eConsumeNoDefault != *aStatus) {
>-        nsCOMPtr<nsIContent> targetContent;
>-        mCurrentTarget->GetContentForEvent(aEvent,
>-                                           getter_AddRefs(targetContent));
>-
>-        nsCOMPtr<nsIWidget> widget = mCurrentTarget->GetNearestWidget();
>-        WidgetDragEvent event(aEvent->mFlags.mIsTrusted,
>-                              NS_DRAGDROP_DRAGDROP, widget);
>-
>-        WidgetMouseEvent* mouseEvent = aEvent->AsMouseEvent();
>-        event.refPoint = mouseEvent->refPoint;
>-        if (mouseEvent->widget) {
>-          event.refPoint += mouseEvent->widget->WidgetToScreenOffset();
>-        }
>-        event.refPoint -= widget->WidgetToScreenOffset();
>-        event.modifiers = mouseEvent->modifiers;
>-        event.buttons = mouseEvent->buttons;
>-        event.inputSource = mouseEvent->inputSource;
>-
>-        nsEventStatus status = nsEventStatus_eIgnore;
>-        nsCOMPtr<nsIPresShell> presShell = mPresContext->GetPresShell();
>-        if (presShell) {
>-          presShell->HandleEventWithTarget(&event, mCurrentTarget,
>-                                           targetContent, &status);
>-        }
>-      }
>-      sLastDragOverFrame = nullptr;
>-      ClearGlobalActiveContent(this);
>-      break;

The last two lines here (sLastDragOverFrame = nullptr;  and   ClearGlobalActiveContent(this) should stay as they relate to the drop event, not the dragdrop event.

>diff --git a/editor/libeditor/nsEditorEventListener.h b/editor/libeditor/nsEditorEventListener.h
>--- a/editor/libeditor/nsEditorEventListener.h
>+++ b/editor/libeditor/nsEditorEventListener.h
>@@ -65,18 +65,17 @@ protected:
>   virtual nsresult MouseUp(nsIDOMMouseEvent* aMouseEvent) { return NS_OK; }
>   virtual nsresult MouseClick(nsIDOMMouseEvent* aMouseEvent);
>   nsresult Focus(nsIDOMEvent* aEvent);
>   nsresult Blur(nsIDOMEvent* aEvent);
>   nsresult DragEnter(nsIDOMDragEvent* aDragEvent);
>   nsresult DragOver(nsIDOMDragEvent* aDragEvent);
>   nsresult DragExit(nsIDOMDragEvent* aDragEvent);
>   nsresult Drop(nsIDOMDragEvent* aDragEvent);
>-  nsresult DragGesture(nsIDOMDragEvent* aDragEvent);
>-
>+  

Remove the extra unneeded whitespace change.


OK, so fix up these cases and submit a new patch and we can try it out. Thanks again.

	Chirag Bhatia
	Comment 6 • 9 years ago

Hi Neil,

Thanks for the help. I made the changes that you asked (attached a new patch file).

After applying the changes, drag and drop seems to work fine for bookmarks and other elements in the browser UI, but I'm still unable to drag and drop links within web pages.

I also keep getting this warning when I try to drag any links within the web pages:

[Child 5253] WARNING: NS_ENSURE_TRUE(node) failed: file /mnt/extgit/mozilla-central/layout/base/nsDocumentViewer.cpp, line 3530

Not sure if this warning is related to the problem I'm facing.

Any ideas what could be causing the problem?

	Neil Deakin Reporter
	Comment 7 • 9 years ago

> [Child 5253] WARNING: NS_ENSURE_TRUE(node) failed: file
> /mnt/extgit/mozilla-central/layout/base/nsDocumentViewer.cpp, line 3530
> 
> Not sure if this warning is related to the problem I'm facing.
>

Not sure. That code is generally used to handle the copy image context menu command, so it shouldn't be related, but it could be.

I'll take a look next week. Thanks!

	Neil Deakin Reporter
	Comment 8 • 9 years ago

Comment on attachment 8613009 [details] [diff] [review]
1162050.2.patch

>       if (initialDataTransfer)
>         initialDataTransfer->SetDropEffectInt(dropEffect);
>     }
>+    sLastDragOverFrame = nullptr;
>+    ClearGlobalActiveContent(this);
>     break;
>-
>-  case NS_DRAGDROP_DROP:
>-    {

The two lines above here will need to go in the NS_DRAGDROP_DROP section. Otherwise, the dragenter/dragexit events won't fire properly. You can see an issue when dragging a link on the tab bar, as the feedback indciator doesn't disappear.

I don't see any issue with dragging and dropping links. Do you have some more specific steps to reproduce? Does it work in a non-e10s window? (Select 'New None-e10s Window' from the File menu)

Otherwise, when you have a new patch we can submit this patch to our 'try' server to run automated tests, and then mark it for a formal review. I'll post a message about this change in the developer mailing lists.

	Chirag Bhatia
	Comment 9 • 9 years ago

Hi Neil,

I've made the changes you mentioned and attached the patch.

I also tried a build by reverting my changes, and it turns out, the dragging and dropping of links does not work. So the change has nothing to do with my code (either some other bad patch I applied or might be another bug). It does work in a non-e10s window though (even after I applied my patch).

	Neil Deakin Reporter
	Comment 10 • 9 years ago

Comment on attachment 8614777 [details] [diff] [review]
1162050.3.patch

Look good, but I couldn't get the patch to apply cleanly. You likely need to make sure you update (pull or rebase) from the source and fix up any conflicts first.

	Chirag Bhatia
	Comment 11 • 9 years ago

Hi Neil,

I did an hg qpop, hg rebase, hg pull --rebase, and then hg import 1162050.3.patch and it got imported without a problem.

Am I doing this wrong, or should I be trying something else? Which file did you get the conflict in?

	Neil Deakin Reporter
	Comment 12 • 9 years ago

I got problems in a few files. However, it looks like the issues are minor, so I just fixed them up manually for me. It may be that you have different whitespace or linebreaks or something like that; that sometimes happens when moving patches between platforms. I attached the patch.

	Chirag Bhatia
	Comment 13 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46d5eb5c88b4

	Chirag Bhatia
	Comment 14 • 9 years ago

Neil,

The tests do not seem to be showing any problems with our code, although you might want to re-check them since this is the first time I've used try server and its automated tests.

I've taken your patch and added a commit message to it.

	Neil Deakin Reporter
	Comment 15 • 9 years ago

Comment on attachment 8616473 [details] [diff] [review]
1162050.4.patch

The try run looks good to me. The patch also looks good, but we should also remove the nsDragAndDrop.js file (hg remove <the file>)

I posted a messaage about this change to the dev-platform list at https://groups.google.com/forum/#!topic/mozilla.dev.platform/thqN2Umpea0

We'll wait a bit to see if anyone has any concerns and then check it in. This should also give some time for the corresponding Thunderbird and Seamonkey bugs to be fixed. Feel free to help out if you'd like.

Thanks for working on this!

	Chirag Bhatia
	Comment 16 • 9 years ago

I've updated the patch which now includes the removal of the nsDragAndDrop.js file.

Let me know if any other change is required. :)

	Kohei Yoshino [:kohei]
	Comment 17 • 9 years ago

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/legacy-non-standard-drag-events-will-be-removed/

	Neil Deakin Reporter
	Comment 18 • 9 years ago

OK, now that all the dependencies are fixed we can check this in. Chirag, are you available to update the patch for checkin?

	Chirag Bhatia
	Comment 19 • 9 years ago

Yes, Neil. What updates do we need to make?

	Neil Deakin Reporter
	Comment 20 • 9 years ago

The patch doesn't apply anymore, likely mainly because bug 895274 changed the event names from macros to enumerations. Functionally, the patch should be ok. Thanks!

	Jorg K (CEST = GMT+2)
	Comment 21 • 8 years ago

Hi, can you please finish this or can I take this over? I'd like to see that landed, preferably early in a release cycle, so we can address any regressions. We've already cut over Thunderbird to using the new events, but we want to make sure that no harm is done when this bug here lands.

What needs to be done? Well the event name changed:
Old: NS_DRAGDROP_GESTURE,  New: eLegacyDragGesture
Old: NS_DRAGDROP_START,    New: eDragStart
Old: NS_DRAGDROP_DROP,     New: eDrop
Old: NS_DRAGDROP_DRAGDROP, New: eLegacyDragDrop

This bug is about the legacy events being removed. You need to adapt your patch accordingly.

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 22 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55924/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 23 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55926/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 24 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55928/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 25 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55930/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 26 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55932/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 27 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/55934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55934/

	Jorg K (CEST = GMT+2)
	Comment 28 • 8 years ago

Assigning to the submitter of the patches ;-)

	Neil Deakin Reporter
	Comment 29 • 8 years ago

Comment on attachment 8757500 [details]
Bug 1162050 - remove instances of eLegacyDragDrop and dragdrop.

https://reviewboard.mozilla.org/r/55934/#review52966

	Neil Deakin Reporter
	Comment 30 • 8 years ago

Comment on attachment 8757499 [details]
Bug 1162050 - Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h.

https://reviewboard.mozilla.org/r/55932/#review52968

	Neil Deakin Reporter
	Comment 31 • 8 years ago

Comment on attachment 8757498 [details]
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp.

https://reviewboard.mozilla.org/r/55930/#review52970

	Neil Deakin Reporter
	Comment 32 • 8 years ago

Comment on attachment 8757497 [details]
Bug 1162050 - Remove use of eLegacyDragGesture from EventStateManager.cpp.

https://reviewboard.mozilla.org/r/55928/#review52964

::: dom/events/EventStateManager.cpp:705
(Diff revision 1)
>      // Flush pending layout changes, so that later mouse move events
>      // will go to the right nodes.
>      FlushPendingEvents(aPresContext);
>      break;
>    }
> -  case eLegacyDragGesture:
> +  case eDragStart:

I don't think the code will ever get called, but we could leave it for now.

	Neil Deakin Reporter
	Comment 33 • 8 years ago

Comment on attachment 8757496 [details]
Bug 1162050 - Remove instances of eLegacyDragGesture and draggesture.

https://reviewboard.mozilla.org/r/55926/#review52962

::: dom/events/DataTransfer.cpp:155
(Diff revision 1)
>    , mDragImageY(aDragImageY)
>  {
>    MOZ_ASSERT(mParent);
>    // The items are copied from aItems into mItems. There is no need to copy
>    // the actual data in the items as the data transfer will be read only. The
> -  // draggesture and dragstart events are the only times when items are
> +  // dragstart event is the only times when items are

only time

	Neil Deakin Reporter
	Comment 34 • 8 years ago

Comment on attachment 8757495 [details]
Bug 1162050 - Remove toolkit/content/nsDragAndDrop.js.

https://reviewboard.mozilla.org/r/55924/#review52972

	Jorg K (CEST = GMT+2)
	Comment 35 • 8 years ago

Sorry, as far as I can see, there are two review issues.

Also, would you mind landing this next week after the branch date on Monday. That will make is easier to address any issues in the same cycle so we wouldn't need uplifts.

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 36 • 8 years ago

Comment on attachment 8757495 [details]
Bug 1162050 - Remove toolkit/content/nsDragAndDrop.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55924/diff/1-2/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 37 • 8 years ago

Comment on attachment 8757496 [details]
Bug 1162050 - Remove instances of eLegacyDragGesture and draggesture.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55926/diff/1-2/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 38 • 8 years ago

Comment on attachment 8757497 [details]
Bug 1162050 - Remove use of eLegacyDragGesture from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55928/diff/1-2/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 39 • 8 years ago

Comment on attachment 8757498 [details]
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55930/diff/1-2/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 40 • 8 years ago

Comment on attachment 8757499 [details]
Bug 1162050 - Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55932/diff/1-2/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 41 • 8 years ago

Comment on attachment 8757500 [details]
Bug 1162050 - remove instances of eLegacyDragDrop and dragdrop.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55934/diff/1-2/

	Jorg K (CEST = GMT+2)
	Comment 42 • 8 years ago

Any movement here? Would be nice to land this well before the next branch date, August 1st.

	Jorg K (CEST = GMT+2)
	Comment 43 • 8 years ago

Have you checked that the patches still apply?

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 44 • 8 years ago

Comment on attachment 8757495 [details]
Bug 1162050 - Remove toolkit/content/nsDragAndDrop.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55924/diff/2-3/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 45 • 8 years ago

Comment on attachment 8757496 [details]
Bug 1162050 - Remove instances of eLegacyDragGesture and draggesture.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55926/diff/2-3/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 46 • 8 years ago

Comment on attachment 8757497 [details]
Bug 1162050 - Remove use of eLegacyDragGesture from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55928/diff/2-3/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 47 • 8 years ago

Comment on attachment 8757498 [details]
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55930/diff/2-3/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 48 • 8 years ago

Comment on attachment 8757499 [details]
Bug 1162050 - Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55932/diff/2-3/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 49 • 8 years ago

Comment on attachment 8757500 [details]
Bug 1162050 - remove instances of eLegacyDragDrop and dragdrop.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55934/diff/2-3/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 50 • 8 years ago

(In reply to Jorg K (GMT+2, PTO during summer, NI me) from comment #43)
> Have you checked that the patches still apply?

If they rebase properly? Yes. I've just pushed the patches rebased on top of the current mozilla-central

	Jorg K (CEST = GMT+2)
	Comment 51 • 8 years ago

Thanks, so I understand you refreshed/rebased the patches as required.

	Carsten Book [:Tomcat]
	Comment 52 • 8 years ago

has conflicts now when trying to checkin so with last merges i guess this needs rebasing

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 53 • 8 years ago

Comment on attachment 8757495 [details]
Bug 1162050 - Remove toolkit/content/nsDragAndDrop.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55924/diff/3-4/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 54 • 8 years ago

Comment on attachment 8757496 [details]
Bug 1162050 - Remove instances of eLegacyDragGesture and draggesture.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55926/diff/3-4/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 55 • 8 years ago

Comment on attachment 8757497 [details]
Bug 1162050 - Remove use of eLegacyDragGesture from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55928/diff/3-4/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 56 • 8 years ago

Comment on attachment 8757498 [details]
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55930/diff/3-4/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 57 • 8 years ago

Comment on attachment 8757499 [details]
Bug 1162050 - Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55932/diff/3-4/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 58 • 8 years ago

Comment on attachment 8757500 [details]
Bug 1162050 - remove instances of eLegacyDragDrop and dragdrop.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55934/diff/3-4/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 59 • 8 years ago

(In reply to Carsten Book [:Tomcat] from comment #52)
> has conflicts now when trying to checkin so with last merges i guess this
> needs rebasing

Hi Carsten, could you give it a try now? Rebased again. Thanks!

	Jorg K (CEST = GMT+2)
	Comment 60 • 8 years ago

No action if you don't put "checkin-needed" or NI.

	Carsten Book [:Tomcat]
	Comment 61 • 8 years ago

Hi Jimmy i get:

unable to find 'editor/libeditor/nsEditorEventListener.h' for patching

when trying to apply the patches. Maybe because of bug 1260651 ?

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 62 • 8 years ago

Comment on attachment 8757495 [details]
Bug 1162050 - Remove toolkit/content/nsDragAndDrop.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55924/diff/4-5/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 63 • 8 years ago

Comment on attachment 8757496 [details]
Bug 1162050 - Remove instances of eLegacyDragGesture and draggesture.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55926/diff/4-5/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 64 • 8 years ago

Comment on attachment 8757497 [details]
Bug 1162050 - Remove use of eLegacyDragGesture from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55928/diff/4-5/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 65 • 8 years ago

Comment on attachment 8757498 [details]
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55930/diff/4-5/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 66 • 8 years ago

Comment on attachment 8757499 [details]
Bug 1162050 - Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55932/diff/4-5/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 67 • 8 years ago

Comment on attachment 8757500 [details]
Bug 1162050 - remove instances of eLegacyDragDrop and dragdrop.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55934/diff/4-5/

	Pulsebot
	Comment 68 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d7f3aa49d4d
Remove toolkit/content/nsDragAndDrop.js. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8fe3acf2e78
Remove instances of eLegacyDragGesture and draggesture. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/f940ad94cc9d
Remove use of eLegacyDragGesture from EventStateManager.cpp. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/11421fcb32b5
Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/af0d7fedc60f
Remove draggesture from comments in EventStateManager.cpp/.h. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/342274a86c0d
remove instances of eLegacyDragDrop and dragdrop. r=enn

	Carsten Book [:Tomcat]
	Comment 69 • 8 years ago

caused bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=31527433&repo=mozilla-inbound

	Pulsebot
	Comment 70 • 8 years ago

Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e91dc7e8e43
Backed out changeset 342274a86c0d 
https://hg.mozilla.org/integration/mozilla-inbound/rev/03e6db7e26dd
Backed out changeset af0d7fedc60f 
https://hg.mozilla.org/integration/mozilla-inbound/rev/283c5f11c92f
Backed out changeset 11421fcb32b5 
https://hg.mozilla.org/integration/mozilla-inbound/rev/dff37b2bd729
Backed out changeset f940ad94cc9d 
https://hg.mozilla.org/integration/mozilla-inbound/rev/578c5f187aae
Backed out changeset f8fe3acf2e78 
https://hg.mozilla.org/integration/mozilla-inbound/rev/604213dfaeb1
Backed out changeset 2d7f3aa49d4d for bustage in DataTransfer.cpp

	Jorg K (CEST = GMT+2)
	Comment 71 • 8 years ago

mFileList was removed in bug 906420 here:
https://hg.mozilla.org/mozilla-central/rev/170fc45fb692#l3.199

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 72 • 8 years ago

Comment on attachment 8757495 [details]
Bug 1162050 - Remove toolkit/content/nsDragAndDrop.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55924/diff/5-6/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 73 • 8 years ago

Comment on attachment 8757496 [details]
Bug 1162050 - Remove instances of eLegacyDragGesture and draggesture.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55926/diff/5-6/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 74 • 8 years ago

Comment on attachment 8757497 [details]
Bug 1162050 - Remove use of eLegacyDragGesture from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55928/diff/5-6/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 75 • 8 years ago

Comment on attachment 8757498 [details]
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55930/diff/5-6/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 76 • 8 years ago

Comment on attachment 8757499 [details]
Bug 1162050 - Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55932/diff/5-6/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 77 • 8 years ago

Comment on attachment 8757500 [details]
Bug 1162050 - remove instances of eLegacyDragDrop and dragdrop.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55934/diff/5-6/

	Carsten Book [:Tomcat]
	Comment 78 • 8 years ago

seems has problems to apply:

patching file toolkit/content/jar.mn
Hunk #1 FAILED at 0
1 out of 2 hunks FAILED -- saving rejects to file toolkit/content/jar.mn.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 79 • 8 years ago

Comment on attachment 8757495 [details]
Bug 1162050 - Remove toolkit/content/nsDragAndDrop.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55924/diff/6-7/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 80 • 8 years ago

Comment on attachment 8757496 [details]
Bug 1162050 - Remove instances of eLegacyDragGesture and draggesture.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55926/diff/6-7/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 81 • 8 years ago

Comment on attachment 8757497 [details]
Bug 1162050 - Remove use of eLegacyDragGesture from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55928/diff/6-7/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 82 • 8 years ago

Comment on attachment 8757498 [details]
Bug 1162050 - Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55930/diff/6-7/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 83 • 8 years ago

Comment on attachment 8757499 [details]
Bug 1162050 - Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55932/diff/6-7/

	Jimmy Wang (:jimicy) - works on e10s stuff Assignee
	Comment 84 • 8 years ago

Comment on attachment 8757500 [details]
Bug 1162050 - remove instances of eLegacyDragDrop and dragdrop.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55934/diff/6-7/

	Pulsebot
	Comment 85 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f53947a62ad
Remove toolkit/content/nsDragAndDrop.js. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/c010bad64aed
Remove instances of eLegacyDragGesture and draggesture. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe482bb7836a
Remove use of eLegacyDragGesture from EventStateManager.cpp. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/158e4fbc8742
Remove the dragdrop event code that is not related to the drop event in from EventStateManager.cpp. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/35a52f370139
Remove draggesture and eLegacyDragDrop from comments in EventStateManager.cpp/.h. r=enn
https://hg.mozilla.org/integration/mozilla-inbound/rev/48f290424a78
remove instances of eLegacyDragDrop and dragdrop. r=enn

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 86 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/5f53947a62ad
https://hg.mozilla.org/mozilla-central/rev/c010bad64aed
https://hg.mozilla.org/mozilla-central/rev/fe482bb7836a
https://hg.mozilla.org/mozilla-central/rev/158e4fbc8742
https://hg.mozilla.org/mozilla-central/rev/35a52f370139
https://hg.mozilla.org/mozilla-central/rev/48f290424a78

	Kohei Yoshino [:kohei]
	Comment 87 • 8 years ago

Updated the site compat doc: https://www.fxsitecompat.com/en-CA/docs/2016/legacy-non-standard-drag-events-have-been-removed/

	Neil Deakin Reporter
	Comment 88 • 8 years ago

Note that dragexit is in the spec now so any comments regarding it should be updated in documentation.

	Kohei Yoshino [:kohei]
	Comment 89 • 8 years ago

Thanks Neil. Just saw the spec and updated the compat doc accordingly.

https://developers.whatwg.org/dnd.html#event-dnd-dragexit

	Eric Shepherd [:sheppy]
	Comment 90 • 8 years ago

Pages updated:

https://developer.mozilla.org/en-US/docs/Web/API/Window/ondragdrop
https://developer.mozilla.org/en-US/Firefox/Releases/50

This wasn’t documented anywhere else outside our Archive area.

	Robert Kaiser
	Comment 91 • 8 years ago

I'm pretty sure this breaks a number of websites out there and make them stop working properly. I myself have noticed drag and drop being broken on NFL.com Fantasy Football (moving players between positions - there is a fallback that works with multiple clicks) and re:dash (editing/rearranging dashboards, no fallback solution available).

	Kohei Yoshino [:kohei]
	Comment 92 • 8 years ago

Looks like Tweetdeck is also broken. I can confirm that pics can no longer be attached with a drag & drop. https://input.mozilla.org/en-US/dashboard/response/6077371

	Neil Deakin Reporter
	Comment 93 • 8 years ago

Please file bugs for those incompatible sites in the Tech Evangelism component.