(no longer active) Reporter
	Description • 9 years ago

We currently just return true if we can translate the command name to an internal command name, but for paste we need to check to make sure that paste can actually succeed (IOW that the caller has chrome privileges.)

	Hallvord R. M. Steen [:hallvors]
	Comment 1 • 9 years ago

(Changing summary slightly because I think that's what you meant..)

	(no longer active) Reporter
	Comment 2 • 9 years ago

Yep, thanks!

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 4 • 9 years ago

oops - queryCommandSupported != queryCommandEnabled

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 6 • 9 years ago

Acknowledge now-failing browserscope tests

	(no longer active) Reporter
	Comment 7 • 9 years ago

Comment on attachment 8604329 [details] [diff] [review]
Return false from document.queryCommandSupported for restricted commands

Review of attachment 8604329 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but we need to have an explicit test for this too.  Can you please add one?  Ideally, the test would be in two parts, one would be a mochitest-plain, testing non-privileged callers of execCommand, and one would be a mochitest-chrome, testing the privileged callers of execCommand.

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 8 • 9 years ago

Added an explicit test for the feature. Instead of using both mochitest-basic and mochitest-chrome, I decided to use SpecialPowers.wrap(document) to get a privileged call. Hopefully that's an acceptable test.

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 10 • 9 years ago

(In reply to Michael Layzell [:mystor] from comment #9)
> try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec92cce1ffcb

Ignore that - wrong bug

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 11 • 9 years ago

try (includes patches for other bugs): https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3ba5f9e6cc5

	Carsten Book [:Tomcat]
	Comment 12 • 9 years ago

this failed to apply:

renamed 1161721 -> 0001-Bug-1161721-Return-false-from-document.queryCommandS.patch
applying 0001-Bug-1161721-Return-false-from-document.queryCommandS.patch
patching file dom/tests/mochitest/general/mochitest.ini
Hunk #1 FAILED at 100
1 out of 1 hunks FAILED -- saving rejects to file dom/tests/mochitest/general/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh 0001-Bug-1161721-Return-false-from-document.queryCommandS.patch

can you take a look, thanks!

	Nika Layzell [:nika] (ni? for response) Assignee
	Comment 13 • 9 years ago

Sorry - I've rebased the patch onto mozilla-central.

	Pulsebot
	Comment 14 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6635e368ea9e

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 15 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/6635e368ea9e

	Jean-Yves Perrier [:teoli]
	Comment 16 • 9 years ago

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported
and
https://developer.mozilla.org/en-US/Firefox/Releases/41