Closed
Bug 1159232
Opened 9 years ago
Closed 9 years ago
Avoid use of template string in GeckoDriver#sendAsync
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
(Keywords: pi-marionette-server)
Attachments
(1 file, 1 obsolete file)
GeckoDriver#sendAsync is called frequently and we know there are performance drawbacks to using template strings. This means we should only use them in infrequently called methods or where it's otherwise inconvenient to use plain strings. https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js?from=marionette/driver.js#325
Assignee | ||
Updated•9 years ago
|
Keywords: ateam-marionette-server
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
/r/7741 - Bug 1159232: Avoid use of template string in GeckoDriver#sendAsync Pull down this commit: hg pull -r 0f73cedd438590b6489fd6e8df34c9ae27e22e5c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8598630 -
Flags: review?(dburns)
Assignee | ||
Comment 2•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b383534bbdfd
Comment 3•9 years ago
|
||
Comment on attachment 8598630 [details] MozReview Request: bz://1159232/ato https://reviewboard.mozilla.org/r/7739/#review6585 Ship It!
Attachment #8598630 -
Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/e14df688e369
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8598630 -
Attachment is obsolete: true
Attachment #8620178 -
Flags: review+
Assignee | ||
Comment 7•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•