Closed
Bug 1155703
Opened 9 years ago
Closed 9 years ago
Replace FrameSendFailureError and FrameSendNotInitializedError with NoSuchWindowError in Marionette server
Categories
(Testing :: Marionette Client and Harness, defect)
Testing
Marionette Client and Harness
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
(Blocks 1 open bug)
Details
(Keywords: pi-marionette-client, pi-marionette-server)
Attachments
(2 files, 1 obsolete file)
We have two errors, FrameSendFailureError and FrameSendNotInitializedError, that are not in compliance with Selenium. It seems we should be able to replace them with NoSuchWindowError to do what Selenium expects. Unfortunately they are widely used in Gaia, so I suggest the following risk management plan: 1. Land a NoSuchWindowException symbol in marionette_driver 2. Upgrade marionette_driver in Gaia and include that symbol anywhere those two exceptions are currently used 3. Change the server to use the new error and remove the outdated ones 4. Remove the outdated exceptions from Gaia 5. Remove the outdated exception symbols from marionette_driver Sound good?
Assignee | ||
Updated•9 years ago
|
Blocks: webdriver
Keywords: ateam-marionette-client,
ateam-marionette-server
Assignee | ||
Comment 1•9 years ago
|
||
1. NoSuchWindowException has already landed in marionette-driver. 2a. The marionette-driver in Gaia has a sufficiently recent version. 2b. https://github.com/mozilla-b2g/gaia/pull/29794 (bug 1159674) introduces NoSuchWindowException
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
/r/7839 - Bug 1155703: Part 1: Correct Marionette to use NoSuchWindowError /r/7841 - Bug 1159674: Part 2: Remove frame send exceptions from Marionette client Pull down these commits: hg pull -r 4c754ffa813d1d5dea0db9909d86b5c27156fcd1 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599252 -
Flags: review?(dave.hunt)
Assignee | ||
Comment 3•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=761e9087ffa8
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/7841/#review6623 Looks good, but we should make sure we have a passing Gip try run before landing this, as it depends on another patch to land first.
Assignee | ||
Comment 5•9 years ago
|
||
Yes, just to be explicit we're expecting the Gip tests to fail until bug 1159674 lands in Gaia and the Gaia reference is bumped on central.
Comment 6•9 years ago
|
||
Comment on attachment 8599252 [details] MozReview Request: bz://1155703/ato https://reviewboard.mozilla.org/r/7837/#review6625
Attachment #8599252 -
Flags: review?(dave.hunt) → review+
Assignee | ||
Comment 7•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d937a61a27c0
Assignee | ||
Comment 8•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e7694d89e0b
Assignee | ||
Updated•9 years ago
|
Summary: Replace FrameSendFailureError and FrameSendNotInitializedError with NoSuchWindowError → Replace FrameSendFailureError and FrameSendNotInitializedError with NoSuchWindowError in Marionette server
https://hg.mozilla.org/mozilla-central/rev/d00a52f922ed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8599252 -
Attachment is obsolete: true
Attachment #8620081 -
Flags: review+
Attachment #8620082 -
Flags: review+
Assignee | ||
Comment 12•9 years ago
|
||
Assignee | ||
Comment 13•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
Comment 14•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•