:glob ✱ Assignee
	Description • 9 years ago

rewrite product/component searching to use jquery-ui instead of yui.

most of the work has already been done in by dkl in bug 1070784.  splitting it out as it's a blocker for a high priority item.

	David Lawrence [:dkl]
	Comment 1 • 9 years ago

The only issue I had was http://localhost/1154730/describecomponents.cgi does not worked when logged out

Error: "The cookies or token provide were not valid or have expired. You may login again to get new cookies or a new token."

	:glob ✱ Assignee
	Comment 2 • 9 years ago

- based off dkl's patch in bug 1070784
- fixes bug where results were skipped
- fixes anon queries
- fixes error message text
- switches default jquery-ui theme to smoothness
- simplifies css and moves jquery-ui fixes into standard/global.css
- replaces ProdCompSearch global with data- attributes
- fixes style and indentation in bmo/global/choose-product.html.tmpl

	David Lawrence [:dkl]
	Comment 3 • 9 years ago

Comment on attachment 8593212 [details] [diff] [review]
1154730_1.patch

Review of attachment 8593212 [details] [diff] [review]:
-----------------------------------------------------------------

Much nicer than my patch, only by a slight margin ;) Your previous proof of concept patch would automatically select the query text when hitting back in the browser. This patch does not do this anymore and prefer the old behavior if you can bring it back. If you agree, fix on commit. r=dkl

::: extensions/ProdCompSearch/web/js/prod_comp_search.js
@@ +18,5 @@
> +            $(id + '-throbber').show();
> +            $(id + '-no_components').hide();
> +            $(id + '-too_many_components').hide();
> +            $(id + '-error').hide();
> +            var url = 'rest.cgi/prod_comp_search/' + encodeURIComponent(request.term) +

This can be simply 'rest' although rest.cgi works as well.

	David Lawrence [:dkl]
	Comment 4 • 9 years ago

BTW, the theme changes should be pushed upstream.

	:glob ✱ Assignee
	Comment 5 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   e9bfbbb..09de3de  master -> master

(In reply to David Lawrence [:dkl] from comment #4)
> BTW, the theme changes should be pushed upstream.

bug 1155522