Closed
Bug 1154691
Opened 9 years ago
Closed 9 years ago
Align Marionette errors with WebDriver errors
Categories
(Testing :: Marionette Client and Harness, defect)
Testing
Marionette Client and Harness
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-client, pi-marionette-server)
Attachments
(1 file, 1 obsolete file)
The list of errors in errors.py is out of date with the ones mandated by the W3C WebDriver specification. Since the server is now _mostly_ up to date, it's time to align the Python client exceptions as well.
Assignee | ||
Comment 1•9 years ago
|
||
We're also missing InvalidSelectorError and InvalidSessionError in the server. We can do these as part of this patch as well.
Keywords: ateam-marionette-client,
ateam-marionette-server
Summary: Align exceptions in errors.py with WebDriver errors → Align Marionette errors with WebDriver errors
Assignee | ||
Comment 2•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f436169871a3
Assignee: nobody → ato
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
/r/7065 - Bug 1154691: Align Marionette with WebDriver errors Pull down this commit: hg pull -r 77d48ec0d5c1027ce4897d25871f78b887b2779b https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato /r/7065 - Bug 1154691: Align Marionette with WebDriver errors Pull down this commit: hg pull -r 77d48ec0d5c1027ce4897d25871f78b887b2779b https://reviewboard-hg.mozilla.org/gecko/
Attachment #8592782 -
Flags: review?(dburns)
Comment 5•9 years ago
|
||
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato https://reviewboard.mozilla.org/r/7063/#review5873 ::: testing/marionette/error.js (Diff revision 1) > + this.code = 13; this should be 32 so that it can be picked up by https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/errors.py#142
Attachment #8592782 -
Flags: review?(dburns)
Assignee | ||
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/7063/#review5879 > this should be 32 so that it can be picked up by https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/errors.py#142 Well spotted, sir!
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato /r/7065 - Bug 1154691: Align Marionette with WebDriver errors Pull down this commit: hg pull -r 5a39fe5749190acb2170025586e6bfdd82e5697c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8592782 -
Flags: review?(dburns)
Updated•9 years ago
|
Attachment #8592782 -
Flags: review?(dburns) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8592782 [details] MozReview Request: bz://1154691/ato https://reviewboard.mozilla.org/r/7063/#review5887 Ship It!
Assignee | ||
Comment 9•9 years ago
|
||
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/cc8eb386f147
Comment 10•9 years ago
|
||
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/ffe700f4d5c4
Comment 11•9 years ago
|
||
had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=8926870&repo=mozilla-inbound
Assignee | ||
Comment 12•9 years ago
|
||
Pushed again to inbound, as gaia has now been bumped: https://hg.mozilla.org/integration/mozilla-inbound/rev/c7eea3e8f98a
Comment 13•9 years ago
|
||
Backed out for Windows w-p-t failures. https://hg.mozilla.org/integration/mozilla-inbound/rev/e00ab1b7ec7c https://treeherder.mozilla.org/logviewer.html#?job_id=9008820&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=9009401&repo=mozilla-inbound
Assignee | ||
Comment 15•9 years ago
|
||
jgraham landed the update to wptrunner in http://hg.mozilla.org/integration/mozilla-inbound/rev/07169eaa246e.
Assignee | ||
Comment 16•9 years ago
|
||
Pushed to inbound again: https://hg.mozilla.org/integration/mozilla-inbound/rev/330f6df11b2f
Comment 17•9 years ago
|
||
(In reply to Andreas Tolfsen (:ato) from comment #16) > Pushed to inbound again: > https://hg.mozilla.org/integration/mozilla-inbound/rev/330f6df11b2f sorry had to back this out again for a backout of bug 1153832 that include some file conflicts without backing this here out
Flags: needinfo?(ato)
https://hg.mozilla.org/mozilla-central/rev/07169eaa246e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 19•9 years ago
|
||
Backout: https://hg.mozilla.org/mozilla-central/rev/ead0ae47fa95
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(ato)
Assignee | ||
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/9a56491b7588
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 22•9 years ago
|
||
Attachment #8592782 -
Attachment is obsolete: true
Attachment #8620047 -
Flags: review+
Assignee | ||
Comment 23•9 years ago
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
Comment 25•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•