Doug Turner (:dougt) Assignee
	Description • 9 years ago

      No description provided.

	Andrew Overholt [:overholt]
	Comment 1 • 9 years ago

Status update: Kit or Nikhil can clarify but I'm under the impression that bug 1153500 and bug 1153504 are the remaining blockers to shipping push on Desktop.

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 2 • 9 years ago

Bug 1153499 - Enable push and sw prefs. r?dougt,ehsan

	(no longer active)
	Comment 3 • 9 years ago

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

https://reviewboard.mozilla.org/r/14467/#review13103

::: modules/libpref/init/all.js:146
(Diff revision 1)
> +pref("dom.serviceWorkers.enabled", true);

You need to adjust the test_*interfaces tests for this.

	(no longer active)
	Comment 4 • 9 years ago

That is r-.  Not sure how to do that on ReviewBoard.

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 5 • 9 years ago

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Bug 1153499 - Enable push and sw prefs. r?dougt,ehsan

	Doug Turner (:dougt) Assignee
	Comment 6 • 9 years ago

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

https://reviewboard.mozilla.org/r/14467/#review13251

Ship It\!

	(no longer active)
	Comment 7 • 9 years ago

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

https://reviewboard.mozilla.org/r/14467/#review13459

Ship It!

::: modules/libpref/init/all.js:146
(Diff revision 2)
> +pref("dom.serviceWorkers.enabled", true);

I think instead of these #ifdefs, it would be better to move this to firefox.js.

::: modules/libpref/init/all.js:4447
(Diff revision 2)
>  pref("dom.push.enabled", true);

This too!

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 8 • 9 years ago

Comment on attachment 8641336 [details]
MozReview Request: Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 9 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=516c3b9ff872

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 10 • 9 years ago

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/95bd6642e4b1c4facd070773d91d00317e74deea
changeset:  95bd6642e4b1c4facd070773d91d00317e74deea
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Wed Jul 15 13:12:44 2015 -0700
description:
Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 11 • 9 years ago

This (and everything else in that push) backed out for mochitest-push crashes:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15512b2f6f41

https://treeherder.mozilla.org/logviewer.html#?job_id=12539301&repo=mozilla-inbound

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 12 • 9 years ago

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/252814d5e628bdf69b1ecfd799fd94e44c1dd56f
changeset:  252814d5e628bdf69b1ecfd799fd94e44c1dd56f
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Wed Jul 15 13:12:44 2015 -0700
description:
Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

	Carsten Book [:Tomcat]
	Comment 13 • 9 years ago

backed out for test failures like :

https://treeherder.mozilla.org/logviewer.html#?job_id=12558193&repo=mozilla-inbound
and
https://treeherder.mozilla.org/logviewer.html#?job_id=12560533&repo=mozilla-inbound

	Pulsebot
	Comment 14 • 9 years ago

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/752bf6f11fbf

	Sylvestre Ledru [:Sylvestre]
	Comment 15 • 9 years ago

Moving the relnote tracking flag from bug 1153503 to here as it seems that the fun is occurring here:

Release Note Request (optional, but appreciated)
[Why is this notable]: Push notifications seems noteworthy.
[Suggested wording]: Implemented Push API
[Links (documentation, blog post, etc)]:

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 16 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34a903cf6651

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 17 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b916cbec4e17

	Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)
	Comment 18 • 9 years ago

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f3e4d353f5798e3947a152c0aaea5e022c3cc27c
changeset:  f3e4d353f5798e3947a152c0aaea5e022c3cc27c
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Wed Jul 15 13:12:44 2015 -0700
description:
Bug 1153499 - Enable push and sw prefs. r=dougt,ehsan

	Carsten Book [:Tomcat]
	Comment 19 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/f3e4d353f579

	Florian Bender
	Comment 20 • 9 years ago
relnote

(In reply to Sylvestre Ledru [:sylvestre] from comment #15)
> Release Note Request (optional, but appreciated)
> [Why is this notable]: Push notifications seems noteworthy.
> [Suggested wording]: Implemented Push API
> [Links (documentation, blog post, etc)]:

I assume this is only available in ServiceWorkers? Then please mention that in the relnotes (to not confuse it with the different Push API implemented for Firefox OS):

[Suggested wording]: Implemented Push API via Service Workers
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Push_API

	Andrew Overholt [:overholt]
	Comment 21 • 9 years ago

I would rather say something like "not SimplePush, the FxOS-only API previously mentioned [here]" since we're not shipping the network interception functionality of Service Workers and don't want confusion by mentioning them.

	Sylvestre Ledru [:Sylvestre]
	Comment 22 • 9 years ago

(In reply to Andrew Overholt [:overholt] from comment #21)
> I would rather say something like "not SimplePush, the FxOS-only API
> previously mentioned [here]" since we're not shipping the network
> interception functionality of Service Workers and don't want confusion by
> mentioning them.
I am not sure to understand what you are proposing. Could you propose a wording? Thanks

	Andrew Overholt [:overholt]
	Comment 23 • 9 years ago

[Suggested wording]: Implemented Push API (note: not the same as SimplePush [https://developer.mozilla.org/en-US/docs/Web/API/Simple_Push_API], the FxOS-only API)
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Push_API

	Sylvestre Ledru [:Sylvestre]
	Comment 24 • 9 years ago

Sorry but most of the Firefox users/developers won't make a confusion with Firefox OS.
Moreover, this is clearly stated in the documentation.
So, I am using Florian proposal for the release notes "Implemented Push API via Service Workers"

	Andrew Overholt [:overholt]
	Comment 25 • 9 years ago

(In reply to Sylvestre Ledru [:sylvestre] from comment #24)
> Sorry but most of the Firefox users/developers won't make a confusion with
> Firefox OS.

But Florian's reason for noting "via Service Workers" was due to potential confusion (see comment 20) :)

I just don't want to have people think we're shipping all of Service Workers.  Please take that into account with your wording.

Thanks.

	Florian Bender
	Comment 26 • 9 years ago

I tried to word it so it is less likely to be confused without being overly long/complicated. For the release, a blog post can point out that although service workers are exposed for the Push functionality, the offline/caching functionality is not yet exposed.

Is there a way to notify HMO writers that they should consider this in their write-ups? Also, someone may write a blog post highlighting the new Push functionality (while pointing out the above) that the release notes can link to.

	jweathersby
	Comment 27 • 9 years ago

(In reply to Andrew Overholt [:overholt] from comment #25)
> (In reply to Sylvestre Ledru [:sylvestre] from comment #24)
> > Sorry but most of the Firefox users/developers won't make a confusion with
> > Firefox OS.
> 
> But Florian's reason for noting "via Service Workers" was due to potential
> confusion (see comment 20) :)
> 
> I just don't want to have people think we're shipping all of Service
> Workers.  Please take that into account with your wording.
> 
> Thanks.

+1

I think it better to just say the Push API is available. We can do a hacks post on it which can clarify if needed. If we say SW we need to say something like "The path to full Service Workers continues with the implementation of the Push API"

	Chris Mills [:cmills]
	Comment 28 • 9 years ago

The Push API has been documented at:

https://developer.mozilla.org/en-US/docs/Web/API/Push_API

See also the interface reference pages (and their member subpages)

https://developer.mozilla.org/en-US/docs/Web/API/PushEvent
https://developer.mozilla.org/en-US/docs/Web/API/PushManager
https://developer.mozilla.org/en-US/docs/Web/API/PushMessageData
https://developer.mozilla.org/en-US/docs/Web/API/PushSubscription

the SW additions:

https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/pushManager
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/onpush
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/onpushsubscriptionchange

and a basic usage guide:

https://developer.mozilla.org/en-US/docs/Web/API/Push_API/Using_the_Push_API

A tech review would be nice at some point. Thanks!

	Sylvestre Ledru [:Sylvestre]
	Comment 29 • 9 years ago

Wording updated to "Ship Push messaging with disabled web notifications from ServiceWorkers"
(thanks to Martin Best for the suggestion).

	Chris Mills [:cmills]
	Comment 30 • 9 years ago

I've added a note to make this clear in the web notifications compat table, and updated the description in the release notes:

https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API#Browser_compatibility
https://developer.mozilla.org/en-US/Firefox/Releases/42#Service_Workers