Closed Bug 1153240 Opened 9 years ago Closed 9 years ago

Incorrect variable assignment of value in GeckoDriver#multiAction

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED WORKSFORME
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: ato, Assigned: ato)

References

Details

(Keywords: pi-marionette-server)

Attachments

(1 file, 1 obsolete file)

We inadvertently fixed another problem in bug 1150041, but the core of the issue is that in our call to the listener we're attempting to extract values and create variables of them in the local scope, and at the same time construct an object with properties to pass to the listener.

The solution is to construct the object with the properties the listener wants by getting the values directly off cmd.parameters.
Assignee: nobody → ato
Status: NEW → ASSIGNED
See bug 1150041 for more debugging information.
Attached file MozReview Request: bz://1153240/ato (obsolete) —
/r/6871 - Bug 1153240: Fix variable assignment of value in GeckoDriver#multiAction

Pull down this commit:

hg pull -r 55b9bb965464c31c7c04b77ae46bc4a82293757c https://reviewboard-hg.mozilla.org/gecko/
Attachment #8590847 - Flags: review?(npark)
Comment on attachment 8590847 [details]
MozReview Request: bz://1153240/ato

https://reviewboard.mozilla.org/r/6869/#review5723

Ship It!
Attachment #8590847 - Flags: review?(npark) → review+
https://hg.mozilla.org/mozilla-central/rev/11de44e77e44
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
I'm seeing the same error on today's latest nightly (gecko hash: 388f5861dc7d), reopening the bug.

http://jenkins1.qa.scl3.mozilla.com/view/Graphics/job/flame-kk-319.mozilla-central.nightly.ui.graphics.reference.bitbar/16/console

0:05:17   File "/var/lib/jenkins/jobs/flame-kk-319.mozilla-central.nightly.ui.graphics.reference.bitbar/workspace/.env/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/marionette.py", line 755, in _handle_error
10:05:17     raise errors.MarionetteException(message=message, status=status, stacktrace=stacktrace)
10:05:17 MarionetteException: MarionetteException: assignment to undeclared variable value
10:05:17 stacktrace:
10:05:17 	GeckoDriver.prototype.multiAction@chrome://marionette/content/driver.js:1927:1
10:05:17 	TaskImpl_run@resource://gre/modules/Task.jsm:330:41
10:05:17 	TaskImpl@resource://gre/modules/Task.jsm:275:3
10:05:17 	createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
10:05:17 	Task_spawn@resource://gre/modules/Task.jsm:164:12
10:05:17 	TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:381:1
10:05:17 	TaskImpl_run@resource://gre/modules/Task.jsm:322:13
10:05:17 	TaskImpl@resource://gre/modules/Task.jsm:275:3
10:05:17 	createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
10:05:17 	Task_spawn@resource://gre/modules/Task.jsm:164:12
10:05:17 	CommandProcessor.prototype.execute@chrome://marionette/content/command.js:158:13
10:05:17 	Dispatcher.prototype.onPacket@chrome://marionette/content/dispatcher.js:75:5
10:05:17 	DebuggerTransport.prototype._onJSONObjectReady/<@chrome://marionette/content/server.js -> resource://gre/modules/devtools/transport/transport.js:471:9
10:05:17 	makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
10:05:17 	makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
10:05:17
Status: RESOLVED → REOPENED
Flags: needinfo?(ato)
Resolution: FIXED → ---
Are you sure this is using a Gecko with the patch in it?  Can you list driver.js and/or show me the gecko.log/logcat?
Flags: needinfo?(ato)
Sorry, apparently I was running a build dependent on the older download job.  The exception no longer happens, but the pinch method isn't working.  (But that should be a separate bug)
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → WORKSFORME
Blocks: 1154432
Attachment #8590847 - Attachment is obsolete: true
Attachment #8620017 - Flags: review+
Blocks: 1229163
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: