:glob ✱ Reporter
	Description • 9 years ago

- determine if it should be displayed in its own module, or in some other form
- add hooks
- update the OF extension to support both show_bug views

	Mark Côté [:mcote]
	Comment 1 • 9 years ago

I'm actually curious how useful this plugin is these days.  I'll ask the sheriffs and random people in #developers.

	:glob ✱ Reporter
	Comment 2 • 9 years ago

mark, is this plugin still useful?

	Mark Côté [:mcote]
	Comment 3 • 9 years ago

I have been told it is, yes.

	:glob ✱ Reporter
	Comment 6 • 8 years ago

OF is currently pref'ed off by default...

(Xidorn Quan [:xidorn] from bug 1239915)
> Since there is a threshold for OrangeFactor Robot to post Bugzilla comment,
> some low frequent intermittent bug may never have related link available. I
> think it makes sense to add a link in Bugzilla to the related OrangeFactor
> page.

once it's added to the bug_model we should enable it by default.

	Mark Côté [:mcote]
	Comment 8 • 8 years ago

Ed Morley says that the OF graph is not as important because OF posts links in bugs now.  I think we can remove this as a blocker for making modal the default UI, although it will still be useful so we'll keep it open.

	Phil Ringnalda (:philor)
	Comment 9 • 8 years ago

At least once per week, I explain to someone who asks "how am I supposed to see the failures after the one you filed this for?" or "has this really not happened for two months?" (or more often, wrongly says "this hasn't happened for two months!") how to pref on the OF display so they aren't at the mercy of a commenting bot which only comments on failures which happen more than a threshold number of times per week, when the commenting isn't broken.

	Mark Côté [:mcote]
	Comment 10 • 8 years ago

Okay, thanks for the comment.  I didn't realize this was generating that level of confusion.  I'm okay (re)prioritizing it.

	David Lawrence [:dkl]
	Comment 11 • 8 years ago

- Add hooks to details module (details_rhs and details_lhs)
- Converted orangefactor JS to jquery for good measure

	David Lawrence [:dkl]
	Comment 12 • 8 years ago

Note. You can use bug 916004 as the bug id in your testing of bug modal view.

	Dylan Hardison [:dylan] (he/him)
	Comment 13 • 8 years ago

Comment on attachment 8755014 [details] [diff] [review]
1153105_1.patch

Review of attachment 8755014 [details] [diff] [review]:
-----------------------------------------------------------------

r-

I see " Orange Factor:
('cf_has_str' [-1)] not supported)
" in edit mode. That doesn't look very nice.

	David Lawrence [:dkl]
	Comment 14 • 8 years ago

(In reply to Dylan William Hardison [:dylan] from comment #13)
> Comment on attachment 8755014 [details] [diff] [review]
> 1153105_1.patch
> 
> Review of attachment 8755014 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r-
> 
> I see " Orange Factor:
> ('cf_has_str' [-1)] not supported)
> " in edit mode. That doesn't look very nice.

Strange I am not seeing that behavior. 

https://www.dropbox.com/s/313lczqglwpm4bz/screenshot-docker%202016-05-22%2017-08-53.png?dl=0

Could be something different between our environments.

dkl

	Dylan Hardison [:dylan] (he/him)
	Comment 15 • 8 years ago

Comment on attachment 8755014 [details] [diff] [review]
1153105_1.patch

Review of attachment 8755014 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/OrangeFactor/template/en/default/hook/bug_modal/edit-details_rhs.html.tmpl
@@ +10,5 @@
> +[% cgi = Bugzilla.cgi %]
> +
> +[% IF orange_factor %]
> +  [% WRAPPER bug_modal/field.html.tmpl
> +     label = "Orange Factor"

add editable = 0 (to make it not look weird under some configurations in edit mode)

	Dylan Hardison [:dylan] (he/him)
	Comment 16 • 8 years ago

Comment on attachment 8755014 [details] [diff] [review]
1153105_1.patch

Review of attachment 8755014 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan with the editable = 0 fix applied as discussed in IRC

	David Lawrence [:dkl]
	Comment 17 • 8 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   a092e46..407add6  master -> master