David Lawrence [:dkl] Assignee
	Description • 9 years ago

BUGZILLA_VERSION() calls 'require Bugzilla' which dies if an array of perl deps are not already installed. We need to wrap this in eval and fall back to the old constant value if error.

dkl

	Dylan Hardison [:dylan] (he/him)
	Comment 2 • 9 years ago

Comment on attachment 8589697 [details] [diff] [review]
1152368_1.patch

Review of attachment 8589697 [details] [diff] [review]:
-----------------------------------------------------------------

r- string eval not needed.

::: Bugzilla/Constants.pm
@@ +225,5 @@
>  # BMO: we don't map exactly to a specific bugzilla version, so override our
>  # reported version with a parameter.
>  sub BUGZILLA_VERSION {
> +    my $bugzilla_version = '4.2+';
> +    eval ("require Bugzilla") || return $bugzilla_version;

there is no reason to use a string eval here. eval { require Bugzilla } should be used.

	Dylan Hardison [:dylan] (he/him)
	Comment 4 • 9 years ago

Comment on attachment 8589708 [details] [diff] [review]
1152368_2.patch

Review of attachment 8589708 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

	David Lawrence [:dkl] Assignee
	Comment 5 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   3eb141e..426d9ce  master -> master