Bryan Garaventa Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; InfoPath.3; rv:11.0) like Gecko

Steps to reproduce:

According to the SVG specification, it should be possible to assign a tooltip for every graphic within an SVG, including the primary SVG by adding a Title element as the first child of either the SVG or G element. This should be reflected in the Accessibility Tree as the accessible name for each graphic. Similarly, a Desc element can be added in the same manner to provide a long description of a graphic, which also should be reflected within the Accessibility Tree for each graphic.

Currently however, none of these accessible names or descriptions are reflected in the Accessibility Tree.

Sample markup:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 310 310" preserveAspectRatio="xMinYMin meet" width="100%" height="100%">
<title> Pie Chart Title </title>
<g transform="translate(157.5 157.5)">
<g class="arc">
<title> Component A 0% </title>
<path class="is-selected" style="fill: #13a7ff; stroke: #13a7ff; stroke-width: 0;" transform="scale(1.05)" d="M 8.75622e-015 -143 A 143 143 0 0 1 2.60797 -142.976 L 0 0 Z" />
</g>
<g class="arc">
<title> Component B 1% </title>
<path class="" style="fill: #0872b0; stroke: #fff; stroke-width: 1px;" transform="" d="M 2.60797 -142.976 A 143 143 0 0 1 7.82044 -142.786 L 0 0 Z" />
</g>
<g class="arc">
<title> Component C 13% </title>
<path class="" style="fill: #79cc26; stroke: #fff; stroke-width: 1px;" transform="" d="M 7.82044 -142.786 A 143 143 0 0 1 107.253 -94.5823 L 0 0 Z" />
</g>
<g class="arc">
<title> Component D 16% </title>
<path style="fill: #3f9818;" d="M 107.253 -94.5823 A 143 143 0 0 1 136.67 42.0758 L 0 0 Z" />
</g>
<g class="arc">
<title> Component E 34% </title>
<path style="fill: #ffd042;" d="M 136.67 42.0758 A 143 143 0 0 1 -106.821 95.0703 L 0 0 Z" />
</g>
<g class="arc">
<title> Component F 37% </title>
<path style="fill: #f86f11;" d="M -106.821 95.0703 A 143 143 0 0 1 -1.53278e-013 -143 L 0 0 Z" />
</g>
</g>
</svg>

To reproduce, use Object Inspector to view the MSAA Name properties for each graphic, and notice that there is no name assigned for any of the child graphics.


Actual results:

Assistive Technologies such as NVDA and JAWS cannot detect any of the child graphics nor their titles because of this bug.


Expected results:

The Accessibility Tree should reflect the accessible Name property for each child graphic that includes a Title element, and the Description property should be set for every graphic that includes a Desc element, which will then be recognized by ATs such as NVDA and JAWS.

	alexander :surkov (:asurkov)
	Comment 1 • 9 years ago

the problem is svg:g doesn't have an accessible and thus svg:title labels nothing. To resolve that we can make it accessible like

section svg:g, having accessible name from title
  graphic svg:path having no name

Still it doesn't make sense to make all svg:g accessible, i.e. svg:g is accessible <=> has title.

Alternatively if svg:g has only one graphic in children, we could not create accessible for svg:g but assigned its title to that graphic.

What do you think?

	Bryan Garaventa Reporter
	Comment 2 • 9 years ago

> Still it doesn't make sense to make all svg:g accessible, i.e. svg:g is accessible <=> has title.

I agree, this would only be valid if a graphic had a textual title or desc, otherwise it would be treated with an implicit role=presentation. I believe there is something in the SVG spec that makes mention of this being an implicit role.

> Alternatively if svg:g has only one graphic in children, we could not create accessible for svg:g but assigned its title to that graphic.

I think I understand, basically it would be good to expose an accessible name for one graphic if one graphic has a title or if the first child of SVG is a title/desc, assigning the name to the main graphic?

I'm not sure where desc fits in, but it would probably be good to track both at the same time since they likely share the same logic.

If it works and can follow the same spec syntax, I'll be happy however it's done :)

	alexander :surkov (:asurkov)
	Comment 4 • 8 years ago
mozreview-review

Comment on attachment 8790296 [details]
Bug 1151648 - Construct accessible objects for SVG elements which have title or desc.

https://reviewboard.mozilla.org/r/78180/#review76708

::: accessible/base/nsAccessibilityService.cpp:1188
(Diff revision 1)
>    }
>  
>    if (!newAcc) {
>      if (content->IsSVGElement()) {
>        nsSVGPathGeometryFrame* pathGeometryFrame = do_QueryFrame(frame);
> -      if (pathGeometryFrame) {
> +      if (pathGeometryFrame && MustBeSVGElementAccessible(content)) {

as I understand it all path elements should be accessible not depending wether they have name or not. Anyway, this seems unrelated with the bug

::: accessible/base/nsAccessibilityService.cpp:1197
(Diff revision 1)
>          newAcc = new EnumRoleAccessible<roles::GRAPHIC>(content, document);
>        } else if (content->IsSVGElement(nsGkAtoms::svg)) {
>          newAcc = new EnumRoleAccessible<roles::DIAGRAM>(content, document);
> +      } else if (content->IsSVGElement(nsGkAtoms::g) &&
> +                 MustBeSVGElementAccessible(content)) {
> +        newAcc = new EnumRoleAccessible<roles::GROUPING>(content, document);

if the function is used only once, then I would keep its body here

::: accessible/tests/mochitest/role/test_svg.html:66
(Diff revision 1)
> +    <g id="g">
> +      <title>g</title>
> +    </g>
>      <rect width="300" height="100" id="rect"
> -          style="fill:rgb(0,0,255);stroke-width:1;stroke:rgb(0,0,0)"/>
> +          style="fill:rgb(0,0,255);stroke-width:1;stroke:rgb(0,0,0)">
> +      <title>rect</title>

why is this change?

	Takeshi Kurosawa :takenspc
	Comment 5 • 8 years ago
mozreview-review

Comment on attachment 8790296 [details]
Bug 1151648 - Construct accessible objects for SVG elements which have title or desc.

https://reviewboard.mozilla.org/r/78180/#review76790

::: accessible/base/nsAccessibilityService.cpp:1188
(Diff revision 1)
>    }
>  
>    if (!newAcc) {
>      if (content->IsSVGElement()) {
>        nsSVGPathGeometryFrame* pathGeometryFrame = do_QueryFrame(frame);
> -      if (pathGeometryFrame) {
> +      if (pathGeometryFrame && MustBeSVGElementAccessible(content)) {

> as I understand it all path elements should be accessible not depending wether they have name or not. Anyway, this seems unrelated with the bug

SVG-AAM intends UAs to only expose path elements which meets the criteria including whether elements have title or desc.

https://w3c.github.io/aria/svg-aam/svg-aam.html#details-id-54

> path
> graphics-symbol role mapping if the element meets the criteria for Including Elements in the Accessibility Tree; otherwise, no accessible object created

::: accessible/tests/mochitest/role/test_svg.html:66
(Diff revision 1)
> +    <g id="g">
> +      <title>g</title>
> +    </g>
>      <rect width="300" height="100" id="rect"
> -          style="fill:rgb(0,0,255);stroke-width:1;stroke:rgb(0,0,0)"/>
> +          style="fill:rgb(0,0,255);stroke-width:1;stroke:rgb(0,0,0)">
> +      <title>rect</title>

If we only expose elements which have title or desc, we need to add title or desc. Otherwise the elements are not exposed.

	alexander :surkov (:asurkov)
	Comment 6 • 8 years ago

(In reply to Takeshi Kurosawa from comment #5)

> > +      if (pathGeometryFrame && MustBeSVGElementAccessible(content)) {
> 
> > as I understand it all path elements should be accessible not depending wether they have name or not. Anyway, this seems unrelated with the bug
> 
> SVG-AAM intends UAs to only expose path elements which meets the criteria
> including whether elements have title or desc.
> 
> https://w3c.github.io/aria/svg-aam/svg-aam.html#details-id-54

ok, fair enough

	alexander :surkov (:asurkov)
	Comment 7 • 8 years ago
mozreview-review

Comment on attachment 8790296 [details]
Bug 1151648 - Construct accessible objects for SVG elements which have title or desc.

https://reviewboard.mozilla.org/r/78178/#review76794

r=me, thank you for fixing this

	alexander :surkov (:asurkov)
	Comment 8 • 8 years ago
mozreview-review

Comment on attachment 8790296 [details]
Bug 1151648 - Construct accessible objects for SVG elements which have title or desc.

https://reviewboard.mozilla.org/r/78180/#review76796

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 8 years ago

Please mark the open issues as resolve in MozReview so that this can be autolanded.

	Robert Longson [:longsonr]
	Comment 10 • 7 years ago

Are there still plans to land this?

	alexander :surkov (:asurkov)
	Comment 11 • 7 years ago

(In reply to Robert Longson from comment #10)
> Are there still plans to land this?

I dropped my open issues sicne they were answered, however I cannot close Takeshi's ones, which are not real issues but answers on my issues. Can they be dropped somehow too?

	Pulsebot
	Comment 15 • 4 years ago

Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2da1b325e97
Construct accessible objects for SVG elements which have title or desc. r=MarcoZ

	Pulsebot
	Comment 18 • 4 years ago

Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13b2c57cb1fe
Construct accessible objects for SVG elements which have title or desc. r=MarcoZ,yzen