Closed
Bug 1150527
Opened 9 years ago
Closed 8 years ago
Remove number based error lookup from Marionette Python client
Categories
(Testing :: Marionette Client and Harness, defect)
Testing
Marionette Client and Harness
Tracking
(firefox-esr52 fixed, firefox53 fixed)
RESOLVED
FIXED
mozilla53
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-client)
Attachments
(2 files)
Once and bug 1150522 and bug 945729 are fixed, we should remove support for lookup of errors by number.
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Keywords: ateam-marionette-client
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811330 [details] Bug 1150527 - Remove error numbers from Marionette Python client; https://reviewboard.mozilla.org/r/93486/#review93824 ::: testing/marionette/client/marionette_driver/errors.py:160 (Diff revision 2) > class UnsupportedOperationException(MarionetteException): > - code = (405,) > status = "unsupported operation" > > > -es_ = [e for e in locals().values() if type(e) == type and issubclass(e, MarionetteException)] > +es_ = [e for e in locals().values() if type( I find this harder to read now, can you put it back to 1 line
Attachment #8811330 -
Flags: review?(dburns) → review+
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811331 [details] Bug 1150527 - Remove unusued InstallGeckoError type; https://reviewboard.mozilla.org/r/93488/#review93826
Attachment #8811331 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8811330 [details] Bug 1150527 - Remove error numbers from Marionette Python client; https://reviewboard.mozilla.org/r/93486/#review93824 > I find this harder to read now, can you put it back to 1 line Sorry, I agree. Sideeffect of running it through autopep8.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 10•8 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c80303bb0436 Remove error numbers from Marionette Python client; r=automatedtester https://hg.mozilla.org/integration/autoland/rev/5cdaf32224f5 Remove unusued InstallGeckoError type; r=automatedtester
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c80303bb0436 https://hg.mozilla.org/mozilla-central/rev/5cdaf32224f5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Comment 12•7 years ago
|
||
Nothing speaks against uplifting this patch to esr52. The referenced dependencies in comment 0 are both fixed in Firefox 40. So this test-only patch should be fine for esr52.
Whiteboard: [checkin-needed-esr52]
|
||
Comment 13•7 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-esr52/rev/4d6649bc5abe https://hg.mozilla.org/releases/mozilla-esr52/rev/8a5309178646
status-firefox-esr52:
--- → fixed
Whiteboard: [checkin-needed-esr52]
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
|
|
||
Comment 14•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•