No-Jun Park [:njpark] Reporter
	Description • 9 years ago

STR:
This started around roughly the same time when the bug 1149167 started, but backing out bug 1075670, it still reproduces.
Using pinch() method in gestures.py (in my case, ran https://github.com/npark-mozilla/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/graphics/test_orientation_zoom.py) causes following error:

TEST-UNEXPECTED-ERROR | test_orientation_zoom.py TestGfxSmokeTestOZ.test_orientation_zoom | MarionetteException: MarionetteException: assignment to undeclared variable value
stacktrace:
	GeckoDriver.prototype.multiAction@chrome://marionette/content/driver.js:1927:1
	TaskImpl_run@resource://gre/modules/Task.jsm:330:41
	TaskImpl@resource://gre/modules/Task.jsm:275:3
	createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
	Task_spawn@resource://gre/modules/Task.jsm:164:12
	TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:381:1
	TaskImpl_run@resource://gre/modules/Task.jsm:322:13
	TaskImpl@resource://gre/modules/Task.jsm:275:3
	createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
	Task_spawn@resource://gre/modules/Task.jsm:164:12
	CommandProcessor.prototype.execute@chrome://marionette/content/command.js:158:13
	Dispatcher.prototype.onPacket@chrome://marionette/content/dispatcher.js:75:5
	DebuggerTransport.prototype._onJSONObjectReady/<@chrome://marionette/content/server.js -> resource://gre/modules/devtools/transport/transport.js:471:9
	makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
	makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14



Traceback (most recent call last):
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_client-0.9-py2.7.egg/marionette/marionette_test.py", line 290, in run
    testMethod()
  File "/Users/mozilla/GitRepo/gaia/tests/python/gaia-ui-tests/gaiatest/tests/graphics/test_orientation_zoom.py", line 11, in test_orientation_zoom
    self.orientation_zoom_check()
  File "/Users/mozilla/GitRepo/gaia/tests/python/gaia-ui-tests/gaiatest/tests/graphics/orientation_zoom_base.py", line 57, in orientation_zoom_check
    self.pinch(image._current_frame_locator, 'in', 20)
  File "/Users/mozilla/GitRepo/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_graphics_test.py", line 197, in pinch
    -disp_x, -disp_y, disp_x, disp_y, duration)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/gestures.py", line 71, in pinch
    multiAction.add(action1).add(action2).perform()
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/marionette.py", line 455, in perform
    return self.marionette._send_message('multiAction', 'ok', value=self.multi_actions, max_length=self.max_length)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/decorators.py", line 36, in _
    return func(*args, **kwargs)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/marionette.py", line 670, in _send_message
    self._handle_error(response)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/marionette.py", line 755, in _handle_error
    raise errors.MarionetteException(message=message, status=status, stacktrace=stacktrace)

Version Info:
Build ID               20150401010204
Gaia Revision          03164bd160809747e6a198e0dba1b7c3ee7789f5
Gaia Date              2015-03-31 14:48:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/18a8ea7c2c62
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150401.043608
Firmware Date          Wed Apr  1 04:36:19 EDT 2015
Bootloader             L1TC000118D0

Perhaps this could be caused by what davehunt suggested, as in https://bugzilla.mozilla.org/show_bug.cgi?id=1149167#c2.  Is there a way to verify this?

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 1 • 9 years ago

This is due to an incorrect variable assignment in https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js?from=marionette/driver.js#1927

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 2 • 9 years ago

Also, thanks for the stack trace.  That's immensely helpful!

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 3 • 9 years ago

This regressed after bug 1107706.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 9 years ago

/r/6473 - Bug 1150041: Fix max_len extraction in GeckoDriver#multiAction

Pull down this commit:

hg pull -r a22302712be7cf2eb8ac49fa2d221b8a2ea923f8 https://reviewboard-hg.mozilla.org/gecko/

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 5 • 9 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9be9e0a2ba5

	David Burns :automatedtester
	Comment 6 • 9 years ago

Comment on attachment 8586808 [details]
MozReview Request: bz://1150041/ato

https://reviewboard.mozilla.org/r/6471/#review5355

Ship It!

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 7 • 9 years ago

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/f8270f649eb3

	No-Jun Park [:njpark] Reporter
	Comment 8 • 9 years ago

Wow, thanks for the fast response!  I'll check out the moz inbound build this afternoon.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 9 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/f8270f649eb3

	No-Jun Park [:njpark] Reporter
	Comment 10 • 9 years ago

I tested the latest nightly, which is after the above changelog, but I still get the error as below.

Here is my version info:
Build ID               20150402010204
Gaia Revision          fb7414fa6f5dbb898adc5bd2bbd9fb75df0d0054
Gaia Date              2015-04-01 17:30:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d222742756c4
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.043758
Firmware Date          Thu Apr  2 04:38:07 EDT 2015
Bootloader             L1TC000118D0

TEST-UNEXPECTED-ERROR | test_orientation_zoom.py TestGfxSmokeTestOZ.test_orientation_zoom | MarionetteException: MarionetteException: assignment to undeclared variable value
stacktrace:
	GeckoDriver.prototype.multiAction@chrome://marionette/content/driver.js:1927:1
	TaskImpl_run@resource://gre/modules/Task.jsm:330:41
	TaskImpl@resource://gre/modules/Task.jsm:275:3
	createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
	Task_spawn@resource://gre/modules/Task.jsm:164:12
	TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:381:1
	TaskImpl_run@resource://gre/modules/Task.jsm:322:13
	TaskImpl@resource://gre/modules/Task.jsm:275:3
	createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
	Task_spawn@resource://gre/modules/Task.jsm:164:12
	CommandProcessor.prototype.execute@chrome://marionette/content/command.js:158:13
	Dispatcher.prototype.onPacket@chrome://marionette/content/dispatcher.js:75:5
	DebuggerTransport.prototype._onJSONObjectReady/<@chrome://marionette/content/server.js -> resource://gre/modules/devtools/transport/transport.js:471:9
	makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
	makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14



Traceback (most recent call last):
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_client-0.9-py2.7.egg/marionette/marionette_test.py", line 290, in run
    testMethod()
  File "/Users/mozilla/GitRepo/gaia/tests/python/gaia-ui-tests/gaiatest/tests/graphics/test_orientation_zoom.py", line 11, in test_orientation_zoom
    self.orientation_zoom_check()
  File "/Users/mozilla/GitRepo/gaia/tests/python/gaia-ui-tests/gaiatest/tests/graphics/orientation_zoom_base.py", line 57, in orientation_zoom_check
    self.pinch(image._current_frame_locator, 'in', 20)
  File "/Users/mozilla/GitRepo/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_graphics_test.py", line 197, in pinch
    -disp_x, -disp_y, disp_x, disp_y, duration)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/gestures.py", line 71, in pinch
    multiAction.add(action1).add(action2).perform()
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/marionette.py", line 455, in perform
    return self.marionette._send_message('multiAction', 'ok', value=self.multi_actions, max_length=self.max_length)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/decorators.py", line 36, in _
    return func(*args, **kwargs)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/marionette.py", line 670, in _send_message
    self._handle_error(response)
  File "/Users/mozilla/.virtualenvs/2.2/lib/python2.7/site-packages/marionette_driver-0.2-py2.7.egg/marionette_driver/marionette.py", line 755, in _handle_error
    raise errors.MarionetteException(message=message, status=status, stacktrace=stacktrace)
TEST-INFO took 127689ms

am I mistaken something? I also get the same result in the latest mozilla-inbound build.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 11 • 9 years ago

Reading your stack trace more carefully, I see it refers to the `value` variable and not `max_len` which I fixed.  `max_len` was still wrong, but it didn't address the issue you reported.

According to https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver/marionette_driver/marionette.py#501 `value` is the correct parameter to extract, so to know more about what’s wrong I’ll need to look at the gecko.log.

Sorry for the inconvenience!

	No-Jun Park [:njpark] Reporter
	Comment 12 • 9 years ago

great! so I wasn't mistaken :).  thanks for looking at this!

	No-Jun Park [:njpark] Reporter
	Comment 13 • 9 years ago

B2G log when the bug happened.  (The error happens almost at the end of the log)

	No-Jun Park [:njpark] Reporter
	Comment 14 • 9 years ago

Hi Andreas, did I provide the correct log in Comment 12? Let me know if you need anything else from me, since this bug makes some of the test suites to fail at the moment.

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 15 • 9 years ago

Bug 1153240 fixes this.