:glob ✱ Assignee
	Description • 9 years ago

bug-modal's editmode is broken for users without editbugs.

some of the fields are not rendered correctly (the read-only view is incorrectly removed), and hitting submit results in:

> Form field dup_id was not defined

	:glob ✱ Assignee
	Comment 1 • 9 years ago

- always display a "---" placeholder for unset values in edit mode when the user cannot change that field
- add the missing bug->check_can_change_field('resolution' ..) check when building the list of valid resolutions
- fix the hiding of the "duplicate of" elements when the resolution isn't initially visible

	David Lawrence [:dkl]
	Comment 2 • 9 years ago

Comment on attachment 8586595 [details] [diff] [review]
1149879_1.patch

Review of attachment 8586595 [details] [diff] [review]:
-----------------------------------------------------------------

Most everything looks fine except one thing I just noticed which may have not been introduced by this issue.

When a bug is already marked RESOLVED/DUPLICATE and I click 'edit', it shows the drop down for status and resolution but still shows the 'Mark as duplicate' instead of the text field with the current duped id. If I then click on 'Mark as duplicate', I see the text field with the current dupe id. This should show by default for bugs already set to DUPLICATE. Can we go ahead and fix this as part this patch or file a new bug?

dkl

	:glob ✱ Assignee
	Comment 3 • 9 years ago

(In reply to David Lawrence [:dkl] from comment #2)
> When a bug is already marked RESOLVED/DUPLICATE and I click 'edit', it shows
> the drop down for status and resolution but still shows the 'Mark as
> duplicate' instead of the text field with the current duped id. If I then
> click on 'Mark as duplicate', I see the text field with the current dupe id.
> This should show by default for bugs already set to DUPLICATE. Can we go
> ahead and fix this as part this patch or file a new bug?

i'll fix that here, since i'm touching that code anyhow.

	:glob ✱ Assignee
	Comment 4 • 9 years ago

- fixes duplicate visibility issue which was introduced by the first patch

	David Lawrence [:dkl]
	Comment 5 • 9 years ago

Comment on attachment 8587184 [details] [diff] [review]
1149879_2.patch

Review of attachment 8587184 [details] [diff] [review]:
-----------------------------------------------------------------

Fixed. r=dkl

	:glob ✱ Assignee
	Comment 6 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   3c87e9f..50a1473  master -> master