Gervase Markham [:gerv] Reporter
	Description • 9 years ago

Can we please have a key combination for the Edit button, as I think it's something people will be wanting to do quite frequently.

Gerv

	:glob ✱
	Comment 1 • 9 years ago

- adds a hotkey of "e" (or ctrl+e, or cmd+e) to enter edit mode
- escape will cancel edit mode

	Gervase Markham [:gerv] Reporter
	Comment 2 • 9 years ago

If Escape cancels edit mode, does it reset all the fields to their original values? If it just hides them, then someone might be in for a surprise if they edit, change some fields, decide not to do that, press Escape, then "just add a comment" and their old changes get submitted...

This seems like an inherent problem with the cancellability of Edit mode.

Gerv

	:glob ✱
	Comment 3 • 9 years ago

(In reply to Gervase Markham [:gerv] from comment #2)
> If Escape cancels edit mode, does it reset all the fields to their original
> values?

yes - https://github.com/mozilla/webtools-bmo-bugzilla/blob/master/extensions/BugModal/web/bug_modal.js#L375

	Dylan Hardison [:dylan] (he/him)
	Comment 4 • 9 years ago

Comment on attachment 8587218 [details] [diff] [review]
1149438_1.patch

Review of attachment 8587218 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Although I tend to hate hotkeys like this, as they make my usage of vimperator more difficult. I'm niche enough to not warrant a userpref though.

	:glob ✱
	Comment 5 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   2c9db01..952a511  master -> master

	:glob ✱
	Comment 6 • 9 years ago

i had to change it to just ctrl+e, because it interfered with normal typing.

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   952a511..6d59489  master -> master