Closed
Bug 1148708
Opened 9 years ago
Closed 9 years ago
Add missing 'override' annotations in DocAccessibleChild.h
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Just hit these warnings when building mozilla-inbound: { In file included from /scratch/work/builds/mozilla-inbound/mozilla/dom/ipc/ContentChild.cpp:24: Warning: -Winconsistent-missing-override in /scratch/work/builds/mozilla-inbound/obj/dist/include/mozilla/a11y/DocAccessibleChild.h: 'RecvCurValue' overrides a member function but is not marked 'override' ../../dist/include/mozilla/a11y/DocAccessibleChild.h:378:16: warning: 'RecvCurValue' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual bool RecvCurValue(const uint64_t& aID, ^ /scratch/work/builds/mozilla-inbound/obj/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessibleChild.h:542:5: note: overridden virtual function is here RecvCurValue( ^ In file included from /scratch/work/builds/mozilla-inbound/mozilla/dom/ipc/ContentChild.cpp:24: Warning: -Winconsistent-missing-override in /scratch/work/builds/mozilla-inbound/obj/dist/include/mozilla/a11y/DocAccessibleChild.h: 'RecvSetCurValue' overrides a member function but is not marked 'override' ../../dist/include/mozilla/a11y/DocAccessibleChild.h:381:16: warning: 'RecvSetCurValue' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual bool RecvSetCurValue(const uint64_t& aID, ^ /scratch/work/builds/mozilla-inbound/obj/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessibleChild.h:546:5: note: overridden virtual function is here RecvSetCurValue( ^ In file included from /scratch/work/builds/mozilla-inbound/mozilla/dom/ipc/ContentChild.cpp:24: Warning: -Winconsistent-missing-override in /scratch/work/builds/mozilla-inbound/obj/dist/include/mozilla/a11y/DocAccessibleChild.h: 'RecvMinValue' overrides a member function but is not marked 'override' ../../dist/include/mozilla/a11y/DocAccessibleChild.h:385:16: warning: 'RecvMinValue' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual bool RecvMinValue(const uint64_t& aID, ^ /scratch/work/builds/mozilla-inbound/obj/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessibleChild.h:551:5: note: overridden virtual function is here RecvMinValue( ^ In file included from /scratch/work/builds/mozilla-inbound/mozilla/dom/ipc/ContentChild.cpp:24: Warning: -Winconsistent-missing-override in /scratch/work/builds/mozilla-inbound/obj/dist/include/mozilla/a11y/DocAccessibleChild.h: 'RecvMaxValue' overrides a member function but is not marked 'override' ../../dist/include/mozilla/a11y/DocAccessibleChild.h:388:16: warning: 'RecvMaxValue' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual bool RecvMaxValue(const uint64_t& aID, ^ /scratch/work/builds/mozilla-inbound/obj/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessibleChild.h:555:5: note: overridden virtual function is here RecvMaxValue( ^ In file included from /scratch/work/builds/mozilla-inbound/mozilla/dom/ipc/ContentChild.cpp:24: Warning: -Winconsistent-missing-override in /scratch/work/builds/mozilla-inbound/obj/dist/include/mozilla/a11y/DocAccessibleChild.h: 'RecvStep' overrides a member function but is not marked 'override' ../../dist/include/mozilla/a11y/DocAccessibleChild.h:391:16: warning: 'RecvStep' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual bool RecvStep(const uint64_t& aID, ^ /scratch/work/builds/mozilla-inbound/obj/ipc/ipdl/_ipdlheaders/mozilla/a11y/PDocAccessibleChild.h:559:5: note: overridden virtual function is here RecvStep( ^ } Just missing some override annotations. Fix coming up, landing with blanket r+ that ehsan granted me for fixes of this sort over in bug 1126447 comment 2.
Assignee | ||
Comment 1•9 years ago
|
||
Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/284d71badea3
Flags: in-testsuite-
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/284d71badea3
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•9 years ago
|
Assignee: nobody → dholbert
You need to log in
before you can comment on or make changes to this bug.
Description
•