Closed
Bug 1147744
Opened 9 years ago
Closed 9 years ago
Green bar with YouTube on Mac
Categories
(Core :: Audio/Video, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla40
People
(Reporter: ajones, Assigned: jya)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(3 files)
685.44 KB,
image/png
|
Details | |
1.25 KB,
patch
|
ajones
:
review+
|
Details | Diff | Splinter Review |
7.66 KB,
patch
|
ajones
:
review+
lizzard
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Replaying the same video several times I got a green bar on the right hand side of the screen.
Reporter | ||
Comment 1•9 years ago
|
||
Asynchronous Pan/Zoom none Device ID 0x6741 GPU Accelerated Windows 1/1 OpenGL (OMTC) Vendor ID 0x1002 WebGL Renderer ATI Technologies Inc. -- AMD Radeon HD 6630M OpenGL Engine windowLayerManagerRemote true AzureCanvasBackend quartz AzureContentBackend quartz AzureFallbackCanvasBackend none AzureSkiaAccelerated 0
Assignee | ||
Comment 2•9 years ago
|
||
Vevo are MSE now? There weren't last time I played one of them. What OS?
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Jean-Yves Avenard [:jya] from comment #2) > Vevo are MSE now? There weren't last time I played one of them. > > What OS? YouTube (see URL). Mac OSX 10.7. Setting the video to 480 lines gives a resolution of 859x480 so we may need to crop the RHS of the output image or something. I can also reproduce it on my MacBook Pro with a GeForce GT 330M.
Assignee | ||
Comment 4•9 years ago
|
||
round to lowest nearest integer
Attachment #8583626 -
Flags: review?(ajones)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Reporter | ||
Updated•9 years ago
|
Attachment #8583626 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Anthony said that didn't fix the problem for him.. I have received the mac mini which exhibited the problem.. just need to find the time to investigate now
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 8•9 years ago
|
||
The default chrome format is 4:2:0, not monochrome \!
Attachment #8589003 -
Flags: review?(ajones)
Reporter | ||
Updated•9 years ago
|
Attachment #8589003 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 9•9 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/d540c29d5c2f remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/801b4019fb00
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d540c29d5c2f https://hg.mozilla.org/mozilla-central/rev/801b4019fb00
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 11•9 years ago
|
||
I verified that this fixed the video problem I reported in duplicate bug 1151291. Jean-Yves: should we uplift this fix to Aurora 39 or Beta 38? AFAIK, we plan to ship MSE for YouTube on OS X in Firefox 38.
Status: RESOLVED → VERIFIED
status-firefox38:
--- → ?
status-firefox39:
--- → ?
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8589003 [details] [diff] [review] Part2. Properly calculate cropping value Approval Request Comment [Feature/regressing bug #]: 1147744 [User impact if declined]: Image displayed may shows invalid pixels [Describe test coverage new/current, TreeHerder]: Minimal testing, ensuring that it didn't introduce obvious regressions and testing against values returned by WMF. [Risks and why]: Low, this is more closely implementing the H264 specs and fixes a invalid default value [String/UUID change made/needed]: None
Flags: needinfo?(jyavenard)
Attachment #8589003 -
Flags: approval-mozilla-beta?
Attachment #8589003 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Keywords: regression
Comment 13•9 years ago
|
||
Comment on attachment 8589003 [details] [diff] [review] Part2. Properly calculate cropping value Approving for uplift to aurora; low-risk regression fix.
Attachment #8589003 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•9 years ago
|
Comment 14•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/40a427f948c9 https://hg.mozilla.org/releases/mozilla-aurora/rev/21784d04ac24
Assignee | ||
Comment 15•9 years ago
|
||
This code path wasn't activated on Mac (and still isn't by default) so not really a regression
Comment 16•9 years ago
|
||
Comment on attachment 8589003 [details] [diff] [review] Part2. Properly calculate cropping value Taking it in case we decide to do something with MSE under Mac. Should be in 38 beta 4.
Attachment #8589003 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 17•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/8f8ebd186863 https://hg.mozilla.org/releases/mozilla-beta/rev/c4a01c159cb6
You need to log in
before you can comment on or make changes to this bug.
Description
•