:glob ✱ Assignee
	Description • 9 years ago

the version number on bmo is problematic:
- it isn't accurate
- it can lead to confusion when determining what features we have (eg. api)

bmo is currently reporting to be "4.2.11+", when really it's "4.2, with lots of changes from 4.4, 5.0, and later, plus a swag of mozilla specific modifications".

that's probably too wordy to have as a version number, so a build id would be better.

we should:
- add a parameter which overrides the BUGZILLA_VERSION constant
- update the push process to add a note to set that to yyyymmdd
- make the version number on index.cgi a link to the recent-changes wiki page

this scheme would make the current BUGZILLA_VERSION "20150323".

	Mark Côté [:mcote]
	Comment 1 • 9 years ago

Nit: maybe we can do "2015-03-23" or "2015.03.23" or something that makes it very simple to figure out the last push date at a quick glance.

	:glob ✱ Assignee
	Comment 2 • 9 years ago

- adds param to 'general' page to override version
- fallsback to "4.2+" if parameter is not set
- in index.html.tmpl we have to hit the param directly, because tt will inline constants.BUGZILLA_VERSION into the compiled template

	Dylan Hardison [:dylan] (he/him)
	Comment 3 • 9 years ago

Comment on attachment 8585939 [details] [diff] [review]
1146960_1.patch

Review of attachment 8585939 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

	:glob ✱ Assignee
	Comment 4 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   50a1473..280c184  master -> master

	Mark Côté [:mcote]
	Comment 5 • 9 years ago

> - make the version number on index.cgi a link to the recent-changes wiki page

Doesn't seem that we did this point.  Also, should this not be a link on every page that display the version?

	David Lawrence [:dkl]
	Comment 6 • 9 years ago

(In reply to Mark Côté [:mcote] from comment #5)
> > - make the version number on index.cgi a link to the recent-changes wiki page
> 
> Doesn't seem that we did this point.  Also, should this not be a link on
> every page that display the version?

i will file a bug and fix the link to the wiki. i do not feel we need the version number on all
pages though. home page only is also the way upstream currently does it.

dkl

	Mark Côté [:mcote]
	Comment 7 • 9 years ago

Yeah never mind about the all-pages part; for some reason I was thinking we display the version on all pages already, and I didn't think we should be linking in some places and not others.