Ben Kelly [:bkelly, not reviewing] Reporter
	Description • 9 years ago

I was trying to reply to the original message in this thread today via gmail:

  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/35_QSL1ABTY

(I was looking at an email, though, not the google group.)

I was trying to trim away excess quote content when the browser crashed.  It seems trying to delete the html elements in the quote triggered the problem.

Here's the ID from about:crashes, but it doesn't seem to be available to view in crash-stats yet:

  8ef32064-eb9a-43a9-a1af-7c54d50f5753

Without the stack I'm not sure what component to put this in yet.

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 1 • 9 years ago

I guess the crash ID is invalid.

If anyone wants to investigate, let me know and I'll forward the email in question to you.

	Boris Zbarsky [:bzbarsky]
	Comment 2 • 9 years ago

Can you reproduce reliably?  If so, want to just reproduce in a debug build?

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 3 • 9 years ago

Ok.  Not sure when I will have to do this.  Might not be today.

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 4 • 9 years ago

Or, I could finally see the dialog box that says "submit crash report" and click ok.

https://crash-stats.mozilla.com/report/index/4faa5c27-5a36-404c-b9ca-7cdb12150324

	Ben Kelly [:bkelly, not reviewing] Reporter
	Comment 5 • 9 years ago

More context:

I first tried selecting a large block of the quote to delete in bulk, but the selection kept getting lost.  So I fell back to just holding the backspace key down for a really long time.  I guess I deleted an important character because that's when the nightly windows went away.

	(no longer active) Assignee
	Comment 6 • 9 years ago

It seems like bug 1088054 accidentally removed a null check here: <http://hg.mozilla.org/mozilla-central/rev/4c792bf9bc28#l2.53>

	(no longer active) Assignee
	Comment 7 • 9 years ago

[Tracking Requested - why for this release]:
This is a regression from bug 1088054 which was landed in the 36 cycle.

	(no longer active) Assignee
	Comment 9 • 9 years ago

This seems to be the #15 top crashes in 36.0.4. :(

https://crash-stats.mozilla.com/topcrasher/products/Firefox/versions/36.0.4?days=7

KaiRo, how can I know how serious this crash is?

	(no longer active) Assignee
	Comment 10 • 9 years ago

Err, this patch actually compiles!

	Robert Kaiser
	Comment 11 • 9 years ago

All I know is what you posted already, that it's #15 on 36.0.4 with ~0.6% of all crashes, which isn't too much in volume. That said, it seems to not exist in 35 or older versions. Also, on pre-release channels it's not in the top 30.

	(no longer active) Assignee
	Comment 12 • 9 years ago

(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #11)
> All I know is what you posted already, that it's #15 on 36.0.4 with ~0.6% of
> all crashes, which isn't too much in volume. That said, it seems to not
> exist in 35 or older versions. Also, on pre-release channels it's not in the
> top 30.

Yeah that completely matches with bug 1088054 having regressed it.  Thanks!

	(no longer active) Assignee
	Comment 13 • 9 years ago

Comment on attachment 8582502 [details] [diff] [review]
Null check the node passed to GetGoodSelPointForNode

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 1088054
User impact if declined: This causes crashes in websites as as webmail or blog editing software.
Testing completed: Locally
Risk to taking this patch (and alternatives if risky): This is essentially risk free, as the fix is a simple null check that takes us to the behavior we had prior to bug 1088054.
String or UUID changes made by this patch: None.

Approval Request Comment
[Feature/regressing bug #]: Not going to repeat the same thing twice.  :-)
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 14 • 9 years ago

Tracking this crash that is close to the top of the top crash list for 36.

	(no longer active) Assignee
	Comment 15 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5cee922ae79

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 16 • 9 years ago

Comment on attachment 8582502 [details] [diff] [review]
Null check the node passed to GetGoodSelPointForNode

We're going to take this very simple crash fix in 37 RC. I am clearing the b2g37 nom as this will be automerged to that branch. I am also marking release- as we're not going to do another point release for 36. Beta+ Aurora+

	Ryan VanderMeulen [:RyanVM]
	Comment 17 • 9 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/8fda35675a3f

	Ryan VanderMeulen [:RyanVM]
	Comment 18 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/9a8251ea2aa3

	Ryan VanderMeulen [:RyanVM]
	Comment 19 • 9 years ago

https://hg.mozilla.org/releases/mozilla-release/rev/8fda35675a3f

	Ryan VanderMeulen [:RyanVM]
	Comment 20 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/a5cee922ae79

	Petruta Horea [:phorea], Desktop QA
	Comment 22 • 9 years ago

Reproduced the initial crash and verified it as fixed using Firefox 37 RC build, Firefox 38 beta 1 and Developer Edition 39.0a2 2015-03-30 (64-bit) under Win 7 64-bit and Mac OS X 10.9.5.

The crash-stats shows only 2 crashes after the fix landed, both for 38.0a2 version, so I'm marking this version as verified yet. It will be checked later in the cycle.

	Petruta Horea [:phorea], Desktop QA
	Comment 23 • 9 years ago

No new crashes lately for Firefox 38, but there are some new reports for 37.0.2, 39.0a2 and 40.0a1.

Robert, should we file a new bug for that ones?
https://crash-stats.mozilla.com/report/index/47db6d1c-2460-4c2b-b1d9-0b4932150424
https://crash-stats.mozilla.com/report/index/bc323988-f597-40f4-b4a0-20fdd2150423
https://crash-stats.mozilla.com/report/index/e38cbe46-7ea3-4d39-bbc6-92f242150423

	Robert Kaiser
	Comment 24 • 9 years ago

(In reply to Petruta Rasa [QA] [:petruta] from comment #23)
> Robert, should we file a new bug for that ones?

Looks like the stacks are different, so probably a new bug. That said, looks like the volume of those is not that huge for now.

	(no longer active) Assignee
	Comment 25 • 9 years ago

Can you please file a bug for this and CC me on it?

	Petruta Horea [:phorea], Desktop QA
	Comment 26 • 9 years ago

Logged bug 1158837.