Closed
Bug 1146855
Opened 9 years ago
Closed 9 years ago
Tooltool manifest for Win32 minidump_stackwalk needs to include Cygwin DLLs
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Tracking
(firefox37 fixed, firefox38 fixed, firefox39 fixed, firefox-esr31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed, b2g-master fixed)
People
(Reporter: ted, Assigned: coop)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
ted
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
bug 1146372 shows a crash on a Windows machine where minidump_stackwalk is failing to execute. It turns out when we moved minidump_stackwalk into tooltool we forgot to include the cygwin support DLLs for it on Windows: http://hg.mozilla.org/build/tools/file/3530a758447a/breakpad/win32 I'm hopeful that fixing this is as simple as uploading those DLLs to tooltool and updating the manifest, and the rest of the mozharness machinery will fetch all the files automatically.
Reporter | ||
Comment 1•9 years ago
|
||
tooltool manifest in question: https://hg.mozilla.org/mozilla-central/file/840cfd5bc971/testing/config/tooltool-manifests/win32/releng.manifest
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → coop
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
I've added the files to tooltool: cyggcc_s-1.dll f4ded2e1638ffa626afb1726e12033f605f309419483b325b1a081c2f168484f472663372052d5af5148271f5b71f2c8eb6aa98c92ce382dc2a1a40d61c70d66 cygstdc++-6.dll 8769662c6b768d261293a833894657aed402276b44b46abf7bbd8c3a6306be701b4a21a907e1ed834edcf51d80f2c423f6884a4ddef6d31f2e535c3ab4840fa7 cygwin1.dll ceb359907ea02d1943f4b527e45d4080a330bd3522db19ab40bf5fd68762366c8330830457ba7784687a98c9df18c147de54d667eccac63d6c56a50d791a5ff4
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8582395 -
Flags: review?(ted)
Reporter | ||
Updated•9 years ago
|
Attachment #8582395 -
Flags: review?(ted) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8582395 [details] [diff] [review] [m-i] Add cygwin dlls to manifest for minidump_stackwalk Review of attachment 8582395 [details] [diff] [review]: ----------------------------------------------------------------- https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f12794ccc988
Attachment #8582395 -
Flags: checked-in+
Comment 5•9 years ago
|
||
derp. Apologies for the regression ted et al. Thank you for addressing this coop the manifest will download the files into the abs_work_dir. On windows this will be: C:\\slave\test\build\ so the stackwalk exe (win32-minidump_stackwalk.exe) will be relative to the dlls you've added in this bug. Which I think means this should work as it aligns how we set up our paths previously (in the tools repo): http://hg.mozilla.org/build/tools/file/3530a758447a/breakpad/win32
Reporter | ||
Comment 6•9 years ago
|
||
If the .exe and .dlls wind up in the same directory everything should be peachy.
Comment 7•9 years ago
|
||
(In reply to Chris Cooper [:coop] from comment #4) > Comment on attachment 8582395 [details] [diff] [review] > [m-i] Add cygwin dlls to manifest for minidump_stackwalk > > Review of attachment 8582395 [details] [diff] [review]: > ----------------------------------------------------------------- > > https://treeherder.mozilla.org/#/jobs?repo=mozilla- > inbound&revision=f12794ccc988 this will need to be merged across trees once on m-c
Comment 9•9 years ago
|
||
I'll uplift this everywhere once I get into the office
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•9 years ago
|
||
uplifted across branches: remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/28f5144c5bd9 remote: https://hg.mozilla.org/releases/mozilla-beta/rev/6042fc978a7f remote: https://hg.mozilla.org/releases/mozilla-release/rev/936c52fa8e88 remote: https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/1be07d63b72f remote: https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/6472bcc4a4fb remote: https://hg.mozilla.org/releases/mozilla-esr31/rev/9aa602a2351c remote: https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/13a5c0a80d86
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
status-firefox37:
--- → fixed
status-firefox38:
--- → fixed
status-firefox-esr31:
--- → fixed
Resolution: --- → FIXED
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/6042fc978a7f https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/1be07d63b72f https://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/6472bcc4a4fb
status-b2g-v2.0M:
--- → fixed
status-b2g-v2.1S:
--- → fixed
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•