Closed Bug 1146780 Opened 9 years ago Closed 9 years ago

treat github and mozreview attachments as patches

Categories

(bugzilla.mozilla.org :: General, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file)

we should display github PR and mozreview attachments as patches:
- patch background
- show 'review' link which takes you directly to gh/rb
Whiteboard: [good first bug][lang=perl]
See Also: → 1183437
bug 1191672 notes they should also trigger the "unassigned bug with patches" warning.
Assignee: nobody → glob
Component: User Interface: Modal → General
Summary: display github PR and mozreview attachments as patches → treat github and mozreview attachments as patches
Whiteboard: [good first bug][lang=perl]
Attached patch 1146780_1.patchSplinter Review
- adds attachment.can_review
- fixes all attachments on bug_model having the yellow "is patch" background
Attachment #8674085 - Flags: review?(dylan)
Comment on attachment 8674085 [details] [diff] [review]
1146780_1.patch

Review of attachment 8674085 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8674085 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   a0fcc8f..0ce40b9  master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: